Define acceptance test for database deliverable #41
Conversation
zacdezgeo
requested review from
bitner,
alukach,
bpstewar,
vincentsarago and
andresfchamorro
docs/acceptance/db.md
Outdated
| Set the database environment variables in `db.env`: | ||
|
|
||
| ```bash | ||
| DB_HOST=localhost |
There was a problem hiding this comment.
It's really handy to just use the standard Postgres environment variables rather than more generic DB_ variables. This allows you to just set the environment and run the app or use psql or any other tooling that uses the standard environment variables without having to set the variables multiple times or to need to use command line parameters. PGPORT, PGDATABASE, PGUSER, PGPASSWORD
There was a problem hiding this comment.
Opened a PR for this specific change.
Add remote database url. Modify attribute naming convention. Remove chunking scripts.
zacdezgeo
force-pushed
the
acceptance/db
branch
from
ff08239 to
1ff3ada
Compare
|
ugh, sorry everyone. I made some mistakes with git here. I pushed a new commit with that replicates the state of the env vars. I deployed the changes to Would love a last look from @vincentsarago , @bitner or @alukach and this would be good to merge! |
What I Changed
Acceptance test documentation for the database deliverable.
How to Test
Follow the steps in the acceptance test.
Other Notes
I'd appreciate a review from @bpstewar, and someone from the DevSeed team (@alukach, @bitner or @vincentsarago)