Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Add users #181

Closed
wants to merge 33 commits into from
Closed

(WIP) Add users #181

wants to merge 33 commits into from

Conversation

AshGodfrey
Copy link
Contributor

@AshGodfrey AshGodfrey commented Aug 18, 2023 •
edited
Loading

Description

Adds userland

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ x] Yes -- https://github.com/workos/workos/pull/22693

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Ash Godfrey and others added 30 commits August 14, 2023 16:49
start adding users
0249bf0
@AshGodfrey
create user (#172)
340c93d
@AshGodfrey
add listusers (#173)
78ae24d
@AshGodfrey
add getuser (#174)
0dc6171
add removeUserFromOrganization
519f03a
fix remove user query params
34f7f08
@AshGodfrey
add user to organization (#176)
2dfd3f3
@AshGodfrey
Add Verify Session (#177)
ed14f99
@AshGodfrey
add complete password reset (#178)
e08b4dd 
Co-authored-by: Ash Godfrey <[email protected]>
@AshGodfrey
add create password reset challenge (#179)
730ab4e 
Co-authored-by: Ash Godfrey <[email protected]>
@AshGodfrey
update code to better match existing SDK structures (#180)
3700142 
Co-authored-by: Ash Godfrey <[email protected]>
@AshGodfrey
Add Authenticate User With Password (#182)
8dcf4b9
@AshGodfrey
rebase (#185)
1f63cac 
Co-authored-by: Ash Godfrey <[email protected]>
rename variables for consistency
89c832e
update remove user from org method for clarity
58410e5
remove verify session
e1e3e05
rename to challenge response
509410e
@AshGodfrey
add send magic auth code (#187)
fea64bf 
Co-authored-by: Ash Godfrey <[email protected]>
@AshGodfrey
Make user updates (#186)
2aec7ae 
* update user

* remove usertype enum

---------

Co-authored-by: Ash Godfrey <[email protected]>
@AshGodfrey
add verifyEmail (#188)
ff2a5d9 
Co-authored-by: Ash Godfrey <[email protected]>
@AshGodfrey
Add Delete User (#189)
0dc98d1
@AshGodfrey
Add update user password (#190)
026145c
@AshGodfrey
fix authenticate methods (#191)
d27e676 
Co-authored-by: Ash Godfrey <[email protected]>
linter + expanded tests
d973898
update add user to org naming conventions
07fe556
improve remove user naming conventions
fa1e58f
consistency updates
eafb728
remove sesions file
08c44e5
fix add users to organization endpoint
02c8e27
@AshGodfrey
update methods (#192)
0b05333 
Co-authored-by: Ash Godfrey <[email protected]>
@AshGodfrey
m2 related updates (#193)
600a27e 
Co-authored-by: Ash Godfrey <[email protected]>
@AshGodfrey
Add listauthfactors method (#194)
d700199 
* add listAuthFactor method

* Add EnrollAuthFactor method (#195)

---------

Co-authored-by: Ash Godfrey <[email protected]>
@ibrahimbutt
Copy link

ibrahimbutt commented Mar 1, 2024 •
edited
Loading

@AshGodfrey is this still being worked on?

@ibrahimbutt
Copy link

ibrahimbutt commented Mar 3, 2024 •
edited
Loading

CC @dliu-workos

@ibrahimbutt
Copy link

ibrahimbutt commented Mar 3, 2024 •
edited
Loading

@oliverzheng @tribble

Can this be approved and merged please? There is no user management support in the SDK, whereas the other SDKs have it. Are you not supporting Kotlin and Java?

Respectfully, I don't understand why this PR is dead, and it certainly reduces my faith in using WorkOS, considering the tooling is not being maintained or developed, especially for something widespread as the JVM. I've been watching this PR for months, and have previously had to go through the pain of using the user management API without the SDK. This time round, it may be easier to go with another option, even though we are very happy with the platform :(

@PaulAsjes
Copy link
Contributor

Hi @ibrahimbutt, apologies for the delay here. I'm going to look into getting this merged.

@southgate
Copy link

Hi @ibrahimbutt, EM on the team here responsible for this API. Landing this PR is something we're planning to work on in the coming weeks. Would that work for your timeline?

@ibrahimbutt
Copy link

Hi @southgate. Glad to hear this is in the pipeline! A few weeks works for our timeline. Thank you!

@ibrahimbutt
Copy link

Hi @southgate, checking in as it has been 3 weeks. Is there an ETA on this?

@southgate
Copy link

Missed this notification. We're getting started on this shortly @ibrahimbutt. Will loop back to you with an ETA later this week.

@AshGodfrey
Add updateUser method (#197)
951524b 
* add update user

* update method names (#198)

Co-authored-by: Ash Godfrey <[email protected]>

---------

Co-authored-by: Ash Godfrey <[email protected]>
@amadeo-workos
Copy link
Contributor

@ibrahimbutt we are going to be actively working on adding user management functionality into the SDK this month. You should expect it to be ready by April 29th.

@amadeo-workos
Copy link
Contributor

Closing this PR in favor of #212, which contains the full support for User Management.

@ibrahimbutt
Copy link

Thank you for the updates @southgate @amadeo-workos!

@amadeo-workos
Copy link
Contributor

@ibrahimbutt

The UM support in the Java SDK has shipped! ⛵ it is under the 3.1.0-beta.user-management1 version. Please check it out and let us know how it goes!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimbutt ibrahimbutt ibrahimbutt approved these changes

@robframpton robframpton robframpton approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AshGodfrey @ibrahimbutt @PaulAsjes @southgate @amadeo-workos @robframpton