Fix two memory leaks (#11)

workleap · Jan 17, 2023 · 42d363c · 42d363c
1 parent 4f7e41d
commit 42d363c
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 6 deletions.
diff --git a/src/GSoft.Extensions.Xunit/BaseIntegrationFixture.cs b/src/GSoft.Extensions.Xunit/BaseIntegrationFixture.cs
@@ -19,6 +19,8 @@ protected BaseIntegrationFixture()
 
     protected override IConfigurationBuilder ConfigureConfiguration(IConfigurationBuilder builder)
     {
+        base.ConfigureConfiguration(builder);
+
         builder.SetBasePath(AppContext.BaseDirectory);
         builder.AddJsonFile("appsettings.json", optional: true, reloadOnChange: false);
         builder.AddJsonFile("appsettings." + this.Environment.EnvironmentName + ".json", optional: true, reloadOnChange: false);

diff --git a/src/GSoft.Extensions.Xunit/BaseIntegrationTest.cs b/src/GSoft.Extensions.Xunit/BaseIntegrationTest.cs
@@ -2,8 +2,8 @@
 
 public abstract class BaseIntegrationTest : BaseIntegrationTest<EmptyIntegrationFixture>
 {
-    protected BaseIntegrationTest(ITestOutputHelper testOutputHelper)
-        : base(new EmptyIntegrationFixture(), testOutputHelper)
+    protected BaseIntegrationTest(EmptyIntegrationFixture fixture, ITestOutputHelper testOutputHelper)
+        : base(fixture, testOutputHelper)
     {
     }
 }

diff --git a/src/GSoft.Extensions.Xunit/BaseUnitFixture.cs b/src/GSoft.Extensions.Xunit/BaseUnitFixture.cs
@@ -60,6 +60,13 @@ protected virtual void Dispose(bool disposing)
         if (disposing)
         {
             this._loggerProvider.Dispose();
+
+            if (this._lazyConfiguration.IsValueCreated)
+            {
+                // ConfigurationRoot can contain disposable configuration providers:
+                // https://github.com/dotnet/runtime/blob/v6.0.0/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationRoot.cs#L99
+                (this._lazyConfiguration.Value as IDisposable)?.Dispose();
+            }
         }
     }
 

diff --git a/src/GSoft.Extensions.Xunit/BaseUnitTest.cs b/src/GSoft.Extensions.Xunit/BaseUnitTest.cs
@@ -6,8 +6,8 @@ namespace GSoft.Extensions.Xunit;
 
 public abstract class BaseUnitTest : BaseUnitTest<EmptyUnitFixture>
 {
-    protected BaseUnitTest(ITestOutputHelper testOutputHelper)
-        : base(new EmptyUnitFixture(), testOutputHelper)
+    protected BaseUnitTest(EmptyUnitFixture fixture, ITestOutputHelper testOutputHelper)
+        : base(fixture, testOutputHelper)
     {
     }
 }

diff --git a/src/GSoft.Extensions.Xunit/PublicAPI.Shipped.txt b/src/GSoft.Extensions.Xunit/PublicAPI.Shipped.txt
@@ -3,7 +3,7 @@ GSoft.Extensions.DependencyInjection.DecorationServiceCollectionExtensions
 GSoft.Extensions.Xunit.BaseIntegrationFixture
 GSoft.Extensions.Xunit.BaseIntegrationFixture.BaseIntegrationFixture() -> void
 GSoft.Extensions.Xunit.BaseIntegrationTest
-GSoft.Extensions.Xunit.BaseIntegrationTest.BaseIntegrationTest(Xunit.Abstractions.ITestOutputHelper! testOutputHelper) -> void
+GSoft.Extensions.Xunit.BaseIntegrationTest.BaseIntegrationTest(GSoft.Extensions.Xunit.EmptyIntegrationFixture! fixture, Xunit.Abstractions.ITestOutputHelper! testOutputHelper) -> void
 GSoft.Extensions.Xunit.BaseIntegrationTest<TFixture>
 GSoft.Extensions.Xunit.BaseIntegrationTest<TFixture>.BaseIntegrationTest(TFixture! fixture, Xunit.Abstractions.ITestOutputHelper! testOutputHelper) -> void
 GSoft.Extensions.Xunit.BaseUnitFixture
@@ -12,7 +12,7 @@ GSoft.Extensions.Xunit.BaseUnitFixture.Configuration.get -> Microsoft.Extensions
 GSoft.Extensions.Xunit.BaseUnitFixture.Dispose() -> void
 GSoft.Extensions.Xunit.BaseUnitFixture.SetXunitOutput(Xunit.Abstractions.ITestOutputHelper! outputHelper) -> void
 GSoft.Extensions.Xunit.BaseUnitTest
-GSoft.Extensions.Xunit.BaseUnitTest.BaseUnitTest(Xunit.Abstractions.ITestOutputHelper! testOutputHelper) -> void
+GSoft.Extensions.Xunit.BaseUnitTest.BaseUnitTest(GSoft.Extensions.Xunit.EmptyUnitFixture! fixture, Xunit.Abstractions.ITestOutputHelper! testOutputHelper) -> void
 GSoft.Extensions.Xunit.BaseUnitTest<TFixture>
 GSoft.Extensions.Xunit.BaseUnitTest<TFixture>.BaseUnitTest(TFixture! fixture, Xunit.Abstractions.ITestOutputHelper! testOutputHelper) -> void
 GSoft.Extensions.Xunit.BaseUnitTest<TFixture>.Dispose() -> void