Update UBE tests #80
Merged
Update UBE tests #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarani
reviewed
Jun 2, 2021
| 2. Connect the Jetpack plugin (it comes pre-installed) to a WP.com account | ||
| 3. By default, Gutenberg is the default editor so no action required there | ||
| 2. Connect Jetpack to the signed in WP.com account | ||
| 3. Visit https://wordpress.com/settings/security, choose newly created site and enable "WordPress.com log in" |
There was a problem hiding this comment.
I agree with this change because it keeps this test focused on Jetpack-connected self-hosted sites. Do you think a separate test should be added at some point to test the "enable Jetpack WP.com SSO flow"?
There was a problem hiding this comment.
I was thinking the same. I'm not sure where the that test should live; in the Jetpack domain or Gutenberg. Regardless it's a good idea to have test coverage around that flow.
There was a problem hiding this comment.
For now I think it might be fine for it to live here, if you agree I'll add one here.
I made an issue to do that here: #81
guarani
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the UBE test steps for a connected Jetpack were unclear. This step was incorrect:
Instead I saw the prompt to "Open Jetpack Security settings" .
I updated the pre steps to first allow logging in with wp.com to 1. simplify the test steps and 2. avoid any future changes to
the Jetpack security auth flows.
I also added a checklist template to the top of the doc