Add action to download metadata from OneSky #563
Conversation
Generated by 🚫 Danger |
| # TODO: Add :android locale codes | ||
| # TODO: Add :glotpress locale codes |
There was a problem hiding this comment.
🎗️ Reminder to add values for android and glotpress too. Once we have values for GlotPress, we might also want to expose a def self.mag16 convenience method too
|
|
||
| # The set of common locale codes mappings known to us | ||
| # | ||
| def self.default |
There was a problem hiding this comment.
💡 API idea: also provide a def self.only(options) method which will expect options to be a Hash with a single key which must be one of the LocaleMap.members, and a value being an Array<String>, so that we can call LocalesMap.only(onesky: %w[fr pt-BR en es it]) to get a subset of the known locales.
We can then implement def self.mag16 by just calling that self.only method with the 16 expected locales, and additionally make it easy for client apps to provide just the custom list of locales they support.
| end | ||
| end | ||
|
|
||
| it 'works' do |
There was a problem hiding this comment.
WIP. We need to add a lot more tests.
Including ones around composite keys (keys which contain . in their name, which OneSky exports as a tree of keys and subkeys split around that .)
AliSoftware
changed the title
What
This is a WIP on migrating our code related to OneSky (the translation platform used by Tumblr apps) from Tumblr-iOS and Tumblr-Android's
Fastfilesinto therelease-toolkitThis work has been paused as other priorities came in the way of its progress and now other projects are taking precedence, but still I wanted to push the existing code to keep track of the progress and be able to come back to it at a later time.
Status
Right now the code for the
download_metadata_from_onesky(which handles store metadata infastlane/metadata/*/*.txt) should be working, and the only thing left for that action is to add more unit tests to cover more cases. So that action pretty close to be ready to ship.Note that the initial plan was to also add
ios_download_translations_from_onesky(to download app strings inLocalizable.strings) andandroid_download_translations_from_onesky(for app strings invalues/strings.xml) actions too. But in practice these could be added separately.