Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the post title selection state to the store and update PostTitle #1240

Closed
wants to merge 2 commits into from
Closed

Move the post title selection state to the store and update PostTitle #1240

wants to merge 2 commits into from

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jul 22, 2019 •
edited
Loading

This is a testing PR for WordPress/gutenberg#16704

Testing Instructions:

Boot the app locally and try the instructions in #1219 to make sure there is no regression when adding a new block

@Tug Tug added the [Type] Enhancement Improves a current area of the editor label Jul 22, 2019
@Tug Tug added this to the 1.10 milestone Jul 22, 2019
@Tug Tug requested review from hypest and mchowning July 22, 2019 14:58
@Tug Tug self-assigned this Jul 22, 2019
mchowning
mchowning approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Tug Tug closed this Jul 26, 2019
@Tug Tug deleted the update/editor/post-title-in-store branch July 26, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

@hypest hypest Awaiting requested review from hypest

Assignees

@Tug Tug

Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@Tug @mchowning