Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CachedAnimatedImageView and related types #23925

Merged
merged 6 commits into from
Dec 24, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 24, 2024

Remove the remaining usages of CachedAnimatedImageView, the type itself, and the related types.

Changes

  • Update MediaItemHeaderView to use AsyncImageView instead of CachedAnimatedImageView
  • Fix code formatting in RichTextView
  • Update AnimatedGifAttachmentViewProvider to use GIFImageView directly (pretty sure it is unused as WPRichTextImage handles these)
  • Remove SolidColorActivityIndicator
  • Remove CachedAnimatedImageView
  • Remove GIFPlaybackStrategy

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Media label Dec 24, 2024
@kean kean added this to the 25.7 milestone Dec 24, 2024
@kean kean changed the base branch from trunk to christmas-feature-branch December 24, 2024 17:21
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean kean merged commit e07e9b0 into christmas-feature-branch Dec 24, 2024
5 of 21 checks passed
@kean kean deleted the task/remove-cached-animated-image branch December 24, 2024 17:22
@kean kean mentioned this pull request Dec 24, 2024
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23925-fbbfcb9
Version25.6
Bundle IDorg.wordpress.alpha
Commitfbbfcb9
App Center BuildWPiOS - One-Offs #11229
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23925-fbbfcb9
Version25.6
Bundle IDcom.jetpack.alpha
Commitfbbfcb9
App Center Buildjetpack-installable-builds #10267
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants