Remove unused code from WordPressShared (#23423)

* Remove WPWalkthroughOverlayView

* Remove DateUtils

* Remove unused code from NSString-Helpers

* Remove UIDevice+Helpers

* Remove wp_reduce

* Remove WPNUXUtility

* Remove WPSharedLogging

* Remove unused code from WPStyleGuide

* Remove unused code from WPTableViewCell

* Remove unused WPShared-Swift header

* Remove unused code from WPDeviceIdentification

* Remove unused #if SWIFT_PACAKGE imports

* Remove unused ConsoleLogger

* Remove unused toStringForPageSections

* Remove NSMutableData extensions

* Remove unused Secret

* Remove unwanted commented-out code

Modules/Sources/WordPressShared/Analytics/AnalyticsEvent.swift

@@ -1,8 +1,5 @@
 import Foundation
-
-#if SWIFT_PACKAGE
 import WordPressSharedObjC
-#endif
 
 /// This struct represents an analytics event.
 /// Declaring this class as final is a design choice to promote a simpler usage and implement events

Modules/Sources/WordPressShared/Utility/CollectionType+Helpers.swift

@@ -1,20 +1,9 @@
 import Foundation
 
-// MARK: - Collection Type Helpers
-//
-extension BidirectionalCollection {
-    public func lastIndex(where predicate: (Self.Iterator.Element) throws -> Bool) rethrows -> Self.Index? {
-        if let idx = try reversed().firstIndex(where: predicate) {
-            return self.index(before: idx.base)
-        }
-        return nil
-    }
-}
-
 extension Collection {
     /// Returns the element at the specified index if it is within bounds, otherwise nil.
     ///
-    public subscript (safe index: Index) -> Element? {
+    public subscript(safe index: Index) -> Element? {
         return indices.contains(index) ? self[index] : nil
     }
 }

Modules/Sources/WordPressShared/Utility/NSBundle+WordPressShared.swift

@@ -9,7 +9,6 @@ extension Bundle {
     /// otherwise it will be the framework bundle.
     ///
     @objc public class var wordPressSharedBundle: Bundle {
-#if SWIFT_PACKAGE
 #if DEBUG
         // Workaround for https://forums.swift.org/t/swift-5-3-swiftpm-resources-in-tests-uses-wrong-bundle-path/37051
         if let testBundlePath = ProcessInfo.processInfo.environment["XCTestBundlePath"],
@@ -18,15 +17,5 @@ extension Bundle {
         }
 #endif
         return Bundle.module
-#else
-        let defaultBundle = Bundle(for: BundleFinder.self)
-        // If installed with CocoaPods, resources will be in WordPressShared.bundle
-        if let bundleURL = defaultBundle.resourceURL,
-           let resourceBundle = Bundle(url: bundleURL.appendingPathComponent("WordPressShared.bundle")) {
-            return resourceBundle
-        }
-        // Otherwise, the default bundle is used for resources
-        return defaultBundle
-#endif
-        }
+    }
 }

Modules/Sources/WordPressShared/Utility/NSDate+Helpers.swift

@@ -179,21 +179,6 @@ extension Date {
         return DateFormatters.shortDateTime.string(from: self)
     }
 
-    @available(*, deprecated, message: "Not used, as far as I can tell – @jkmassel, Jan 2021")
-    fileprivate func toStringForPageSections() -> String {
-        let interval = timeIntervalSinceNow
-
-        if interval > 0 && interval < 86400 {
-            return NSLocalizedString("later today", comment: "Later today")
-        } else {
-            let formatter = RelativeDateTimeFormatter()
-            formatter.unitsStyle = .short
-            formatter.dateTimeStyle = .named
-
-            return formatter.localizedString(fromTimeInterval: interval)
-        }
-    }
-
     /// Returns the date components object.
     ///
     public func dateAndTimeComponents() -> DateComponents {
@@ -244,11 +229,6 @@ extension NSDate {
         return (self as Date).shortStringWithTime()
     }
 
-    @available(*, deprecated, message: "Scheduled for removal with FormatterKit – if it's still used, we'll rewrite it with modern APIs")
-    @objc public func toStringForPageSections() -> String {
-        return (self as Date).toStringForPageSections()
-    }
-
     /// Returns the date components object.
     ///
     @objc public func dateAndTimeComponents() -> NSDateComponents {

Modules/Sources/WordPressShared/Utility/RichContentFormatter.swift

@@ -1,9 +1,6 @@
 import Foundation
 import UIKit
-
-#if SWIFT_PACKAGE
 import WordPressSharedObjC
-#endif
 
 /// Contains methods for formatting post or comment content for display.
 ///

Modules/Sources/WordPressShared/Utility/String+Helpers.swift

@@ -1,8 +1,5 @@
 import Foundation
-
-#if SWIFT_PACKAGE
 import WordPressSharedObjC
-#endif
 
 extension String {
     public func stringByDecodingXMLCharacters() -> String {

Modules/Sources/WordPressShared/Utility/String+RemovingMatches.swift

@@ -1,8 +1,5 @@
 import Foundation
-
-#if SWIFT_PACKAGE
 import WordPressSharedObjC
-#endif
 
 extension String {
 
@@ -15,7 +12,7 @@ extension String {
         do {
             regex = try NSRegularExpression(pattern: pattern, options: options)
         } catch {
-            WPSharedLogError("Error parsing regex: \(error)")
+            assertionFailure("Failed to create regex: \(error)")
             return self
         }
 

Modules/Sources/WordPressShared/Views/WPStyleGuide+DynamicType.swift

@@ -1,9 +1,6 @@
 import Foundation
 import UIKit
-
-#if SWIFT_PACKAGE
 import WordPressSharedObjC
-#endif
 
 /// Extension on WPStyleGuide to use Dynamic Type fonts.
 ///

Modules/Sources/WordPressShared/Views/WPStyleGuide+SerifFonts.swift

@@ -1,9 +1,6 @@
 import Foundation
 import UIKit
-
-#if SWIFT_PACKAGE
 import WordPressSharedObjC
-#endif
 
 /// WPStyleGuide Extension to use serif fonts.
 ///

Modules/Sources/WordPressShared/WordPressShared.swift

@@ -1,25 +1 @@
-#if SWIFT_PACKAGE
-
 @_exported import WordPressSharedObjC
-
-#endif
-
-func WPSharedLogError(_ format: String, _ arguments: CVarArg...) {
-    withVaList(arguments) { WPSharedLogvError(format, $0) }
-}
-
-func WPSharedLogWarning(_ format: String, _ arguments: CVarArg...) {
-    withVaList(arguments) { WPSharedLogvWarning(format, $0) }
-}
-
-func WPSharedLogInfo(_ format: String, _ arguments: CVarArg...) {
-    withVaList(arguments) { WPSharedLogvInfo(format, $0) }
-}
-
-func WPSharedLogDebug(_ format: String, _ arguments: CVarArg...) {
-    withVaList(arguments) { WPSharedLogvDebug(format, $0) }
-}
-
-func WPSharedLogVerbose(_ format: String, _ arguments: CVarArg...) {
-    withVaList(arguments) { WPSharedLogvVerbose(format, $0) }
-}