Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add campaigns/objectives endpoint #3095

Merged
merged 12 commits into from
Sep 19, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Sep 14, 2024

This adds campaigns/objectives endpoint.
Most codes are similar to endpoints in BlazeCampaignStore, you can compare changes with the targeting/page-topics endpoint.
This also adds a new table, BlazeCampaignObjectives to store fetched objectives.
This can be tested in woocommerce/woocommerce-android#12616.

@JorgeMucientes
Copy link
Contributor

Hey @irfano I've pushed a couple of commits to this PR:

  • 08edcdf Added suitableForDescriotion missing field. This field is needed to display what the objective is good for:
  • Move the BlazeObjectivesDao out of BlazeCampaignsDao to its own class. Campaign entities are not referencing or related to the Objective so I think there's no reason for putting them together in the same DAO.

Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @irfano, the changes look good and I could test them and check they work as expected. I'll approve and update the depending PR once this is merged and FluxC artifact built.

@JorgeMucientes JorgeMucientes merged commit 8667e16 into trunk Sep 19, 2024
13 checks passed
@JorgeMucientes JorgeMucientes deleted the feature/campaigns-objectives-endpoint branch September 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants