-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nullability Annotations to Java Classes] Add Missing Nullability Annotations to Discovery
Network Client Classes (safe
)
#2872
[Nullability Annotations to Java Classes] Add Missing Nullability Annotations to Discovery
Network Client Classes (safe
)
#2872
Conversation
Warning: "Exception 'org.wordpress.android.fluxc.network.discovery .SelfHostedEndpointFinder.DiscoveryException' is never thrown in the method"
Warning: "Raw use of parameterized class 'WPAPIGsonRequest'"
Warnings: "Commented out code (7 lines)" There exist a TODO related to both those commented-out code, which is about adding support for HTTP AUTH and self-signed SSL WP-API sites.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
Warning: "Typo: In word 'Peform'"
Warning: "Exception 'org.wordpress.android.fluxc.network.discovery .SelfHostedEndpointFinder.DiscoveryException' is never thrown in the method"
FYI: 'nn-a' stands for 'non-null annotation'.
FYI: 'nn-a' stands for 'non-null annotation'.
FYI: 'nn-a' stands for 'non-null annotation'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
Warning: "Typo: In word 'begining'"
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
FYI: 'n-a' stands for 'nullability annotations'.
…ndroid into analysis/add-missing-nullability-annotations-to-discovery-clients
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @ParaskP7, thanks for handling this.
I reviewed the code, and I tested the changes with WCAndroid, and there are no compile errors.
👋 @hichamboushaba and thanks so much for reviewing and testing this, you are awesome! 🙇 ❤️ 🚀 FYI: @irfano I'll be also waiting any input from you, else a quick 👍, that is before proceeding with merging this, just so that I know you are aware of this change merging into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I conducted smoke tests on signing in, signing out, and site-fetching screens for WordPress.com and a self-hosted site. Everything appears to be working fine 🟢.
I also skimmed the code changes; they all seem safe.
Awesome, thank you so much for the skim review, testing and merging this @irfano , you rock! 🙇 ❤️ 🚀 |
Parent #2798
This PR adds any missing nullability annotation to DiscoveryWPAPIRestClient.java and DiscoveryXMLRPCClient.java, all its related response classes and anything in between (ie.
AccountStore
,SiteWPAPIRestClient
).FYI.1: This change is
safe
, meaning that there shouldn't be any (major) compile-time changes associated with this change. Having said that, testing is highly recommended since the changes in this PR can affect one or more clients (ie. JP/WPAndroid, WCAndroid, etc)FYI.2: An analysis on
AccountStore
,SiteWPAPIRestClient
and their usages with our main clients suggests that this store is being utilizing by both, the JP/WPAndroid and WCAndroid clients.PS.1: @hichamboushaba I added you as the main reviewer, randomly so, since I just wanted someone from the WooCommerce mobile team to be aware of and sign-off on that change for both. Feel free to merge this PR directly yourself if you deem so.
PS.2: @irfano I am also adding you as an extra reviewer, randomly so, since I want someone from the Jetpack/WordPress mobile team to be aware of this change as well. However, there is no need for you to review it as well, thus duplicating the review work. Having one team member from either of the mobile teams reviewing and testing this change is enough for this change.
Nullability Annotation List:
Nullability Checks List:
Warnings Resolutions List:
Warnings Suppression List:
Refactor List:
Docs List:
Associated Clients
It is highly recommending that this change is being tested on the below associated clients:
To Test (
REST
):FluxC Example
app via theSIGN IN & FETCH SITES
,SIGH OUT
&SIGNED OUT ACTIONS
screens. Verify everything is working as expected.To Test (
XMLRPC
):FluxC Example
app via theSIGN IN & FETCH SITES
,SIGH OUT
&SIGNED OUT ACTIONS
screens. Verify everything is working as expected.