Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nullability Annotations to Java Classes] Replace org.jetbrains with androidx annotations #2804

Merged
merged 2 commits into from
Aug 11, 2023
Merged

[Nullability Annotations to Java Classes] Replace org.jetbrains with androidx annotations #2804

merged 2 commits into from
Aug 11, 2023

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Aug 9, 2023 •
edited
Loading

Parent #2795
Closes #2803

This PR replaces:

  • All occurrences of org.jetbrains.annotations.Nullable with the androidx.annotation.Nullable annotation, and
  • All occurrences of org.jetbrains.annotations.NotNull with the androidx.annotation.NonNull annotation.

To test:

  1. There is nothing much to test here.
  2. Verifying that all the CI checks are successful should be enough.
  3. However, if you really want to be thorough, quickly smoke test the example app and see if it is working as expected.

@ParaskP7 ParaskP7 requested a review from mkevins August 9, 2023 10:18
@ParaskP7 ParaskP7 self-assigned this Aug 9, 2023
mkevins
mkevins approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job tracking these down Petros! 👍

@ParaskP7 ParaskP7 merged commit 57ef814 into trunk Aug 11, 2023
@ParaskP7 ParaskP7 deleted the analysis/replace-org.jetbrains-with-androidx-annotations branch August 11, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

Assignees

@ParaskP7 ParaskP7

Labels
Core Tech Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullability Annotations to Java Classes - Replace org.jetbrains with androidx Annotations
2 participants
@ParaskP7 @mkevins