-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Faster editor start #9370
Conversation
The full parsing involves adjusting the visual newlines, and that is a costly operation (according to the profiler). When we can, we can use the the fast parsing variant.
The progress indicator doesn't disappear when I rotate the device. |
Good catch @daniloercoli , fixed with 8db163b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Long post are loaded fine, without ANR, even on older devices.
Same is for posts with lot of pictures.
I can confirm this works wayyyy better on Gutenberg. 🎉 GutenbergGutenberg seems to be behaving super nice in this regard. Tested rotating, long posts, short posts, uploading images, coming out and back into the editor while uploading, etc. One thing that appears now that the spinner is shown when loading, in HTML mode we may want to also use something along those lines when saving, as it seems it takes a bit for things to get ready to be passed to the
I also tested quickly switching from Visual to HTML mode in Gutenberg while the spinner is visible, several times. I only got an ANR once, but then was not able to reproduce and everything seemed to run smoothly. AztecWhat follows are tests on Aztec alone, but shouldn't be a blocker for this set of PRs given they actually do improve Gutenberg itself.
|
Thanks for the review passes @daniloercoli and @mzorz ! @mzorz , I opened wordpress-mobile/gutenberg-mobile#713 for the issue you reported while switching modes and wordpress-mobile/gutenberg-mobile#714 for the one about switching editors. Will merge this now (when the rest of the PR domino is ready that is), thanks! |
Addresses wordpress-mobile/gutenberg-mobile#672
Currently, the editor has 2 stages during its startup of Gutenberg mobile:
a. The first is some preprocessing happening before the
EditPostActivity
becomes visibleb. The ReactNative app boot itself
This PR addresses only the first stage and introduces a few performance optimizations:
As an extra touch that can help with UX, this PR adds a small progress indicator, visible while the Gutenberg RN app is initializing, parses and renders the post for the first time.
Sibling PRs:
To test:
Update release notes:
RELEASE-NOTES.txt
.