Duplicate the regular login flow to allow application password first iteration #21914

adalpari · 2025-05-27T12:56:24Z

Description

This PR is the first iteration to add the ability to use the Application Password login as the main login entry point when a user tries to log into a new self-hosted site.

Note: this PR is not using those credentials yet, it's just offering the option and storing them into an existing site

Testing instructions

Log into a self-hosted site

Verify you are seeing the XML login (not the webview Application Password one)

Enable the Experimental Feature called "Application Password log in"
Go to your user screen and tap on Log into WordPRess.com to get the log in screen again
Write a non-selfhosted url and try to log in

Verify you see an error saying that Application Password log in is not available

Log into a self-hosted site (please use the same one as in point 1 since creating a new one is not supported yet)

Verify you see the WebView with the Application Password log in.
Verify you see the credentials stores message (toast + logs)

WP_RS   com.jetpack.android.beta  D  Found authorization for https://vanilla.wpmt.co URL: https://vanilla.wpmt.co/wp-admin/authorize-application.php?app_name=android-jetpack-client&success_url=jetpack%3A%2F%2Fapp-pass-authorize
WP_RS  com.jetpack.android.beta  D  Saved application password credentials for: https://vanilla.wpmt.co

Screen_recording_20250527_180852.mp4

Please do other smoke tests to discover possible bugs

…-flow-to-allow-Application-Password # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/applicationpassword/ApplicationPasswordViewModelSlice.kt # WordPress/src/main/res/values/strings.xml

dangermattic · 2025-05-27T12:57:10Z

	3 Warnings
⚠️	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2025-05-27T13:10:54Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21914-e62e43d
	Commit	`e62e43d`
	Direct Download	`wordpress-prototype-build-pr21914-e62e43d.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2025-05-27T13:12:35Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21914-e62e43d
	Commit	`e62e43d`
	Direct Download	`jetpack-prototype-build-pr21914-e62e43d.apk`

Note: Google Login is not supported on these builds.

…-flow-to-allow-Application-Password

…ow-Application-Password' of https://github.com/wordpress-mobile/WordPress-Android into feature/CMM-398-duplicate-the-regular-login-flow-to-allow-Application-Password

codecov · 2025-05-27T16:12:38Z

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 39.32%. Comparing base (90525bb) to head (e62e43d).
Report is 1 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...i/accounts/login/ApplicationPasswordLoginHelper.kt	74.19%	5 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #21914   +/-   ##
=======================================
  Coverage   39.32%   39.32%           
=======================================
  Files        2138     2138           
  Lines      100404   100404           
  Branches    15415    15415           
=======================================
  Hits        39479    39479           
  Misses      57441    57441           
  Partials     3484     3484

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull Request Overview

This PR introduces the first iteration of the Application Password login option by duplicating the regular login flow and modifying the underlying networking and UI components. Key changes include:

Adding a new error string for unsupported Application Password flows.
Changing the visibility and API of the LoginSiteAddressValidator.
Creating new fragments, view models, and tests for the Application Password login flow and updating the login activity and navigator to support it.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
libs/login/src/main/res/values/strings.xml	Added error string for unsupported Application Password authentication.
libs/login/src/main/java/org/wordpress/android/login/LoginSiteAddressValidator.java	Made the validator public and updated method visibility.
WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/applicationpassword/ApplicationPasswordViewModelSliceTest.kt	Updated test cases to use the new helper method for authorization URL retrieval.
WordPress/src/test/java/org/wordpress/android/ui/accounts/login/applicationpassword/LoginSiteApplicationPasswordViewModelTest.kt	Added new tests for the Application Password ViewModel.
WordPress/src/test/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelperTest.kt	Updated tests to reflect changes in URL parameter appending logic.
WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/applicationpassword/ApplicationPasswordViewModelSlice.kt	Removed internal API discovery logic and integrated the helper’s method.
WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteFragment.kt	Updated navigation to use the new Application Password login path via the activity navigator.
WordPress/src/main/java/org/wordpress/android/ui/accounts/login/applicationpassword/LoginSiteApplicationPasswordViewModel.kt	Added new ViewModel for application password login.
WordPress/src/main/java/org/wordpress/android/ui/accounts/login/applicationpassword/LoginSiteApplicationPasswordFragment.kt	Implemented the new fragment for Application Password login.
WordPress/src/main/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelper.kt	Refactored error handling and consolidated Uri-building logic inside a wrapper.
WordPress/src/main/java/org/wordpress/android/ui/accounts/LoginActivity.java	Updated logic to choose between the traditional and Application Password login flows based on feature flags.
WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt	Centralized custom tabs logic by adding a new method to launch Application Password logins.
WordPress/src/main/java/org/wordpress/android/modules/ViewModelModule.java	Bound the new Application Password ViewModel for DI.
WordPress/src/main/java/org/wordpress/android/modules/AppComponent.java	Injected the new Application Password Fragment.

Comments suppressed due to low confidence (3)

libs/login/src/main/java/org/wordpress/android/login/LoginSiteAddressValidator.java:16

Increasing the visibility from package-private to public may expose internal APIs; ensure this change aligns with the intended design and usage.

public class LoginSiteAddressValidator {

WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/applicationpassword/ApplicationPasswordViewModelSlice.kt:79

Confirm that the removal of internal error handling in favor of relying on the helper’s exception management covers all relevant edge cases in production.

val authorizationUrlComplete = applicationPasswordLoginHelper.getAuthorizationUrlComplete(site.url)

WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt:217

Consolidating the custom tabs launch logic here improves code reuse; ensure that all similar implementations elsewhere have been updated to leverage this method.

fun openApplicationPasswordLogin(activity: Activity, url: String) {

WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt

...ress/src/main/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelper.kt

nbradbury

Changes look good! I left a couple of comments which you may or may not want to address.

adalpari · 2025-05-28T14:06:06Z

Thank you for the suggestions. I've now made the changes, so it should be ready to go :)

…-flow-to-allow-Application-Password

sonarqubecloud · 2025-05-28T14:31:14Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adalpari added 14 commits May 26, 2025 14:57

Adding new experimental feature

5a627ff

Hidding it for non debul builds

c1477aa

Fixing test

54a1699

Added new fragment

389b746

Modifying fragment

6e36f30

Some cleaning

c5b713f

Adding viewmodel

2f2a598

Moving code out of the library

6a7aef8

Some more cleaning

bdd84d7

Refactoring duplicated discovery functions

35ef2b2

Emitting events

254f2c6

OPening webview

aeacee0

detekt

6750516

adalpari added the [Type] Task label May 27, 2025

adalpari added 10 commits May 27, 2025 15:51

Adding the feature check

661ef86

Fixing ApplicationPasswordViewModelSliceTest

63feec0

Fixing tests

e5c6f72

detekt

e4db72b

Some refactor and erro handling

f02d233

Merge branch 'trunk' into feature/CMM-398-duplicate-the-regular-login…

94d69f2

…-flow-to-allow-Application-Password

Using navigator do de-duplicate some code

afe27c5

Adding custom error

c879538

Merge branch 'feature/CMM-398-duplicate-the-regular-login-flow-to-all…

e331b2c

…ow-Application-Password' of https://github.com/wordpress-mobile/WordPress-Android into feature/CMM-398-duplicate-the-regular-login-flow-to-allow-Application-Password

Adding some tests

e9cd8e5

adalpari marked this pull request as ready for review May 27, 2025 16:13

adalpari requested review from Copilot and nbradbury May 27, 2025 16:14

Copilot AI reviewed May 27, 2025

View reviewed changes

adalpari requested a review from Copilot May 27, 2025 16:31

Copilot AI reviewed May 27, 2025

View reviewed changes

nbradbury self-assigned this May 28, 2025

nbradbury reviewed May 28, 2025

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/ActivityNavigator.kt Outdated Show resolved Hide resolved

nbradbury reviewed May 28, 2025

View reviewed changes

...ress/src/main/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelper.kt Show resolved Hide resolved

nbradbury approved these changes May 28, 2025

View reviewed changes

PR suggestions

6e6bcb1

Merge branch 'trunk' into feature/CMM-398-duplicate-the-regular-login…

9e8e513

…-flow-to-allow-Application-Password

adalpari enabled auto-merge (squash) May 28, 2025 14:06

Merge branch 'trunk' into feature/CMM-398-duplicate-the-regular-login…

e62e43d

…-flow-to-allow-Application-Password

adalpari merged commit a306dba into trunk May 28, 2025
23 of 26 checks passed

adalpari deleted the feature/CMM-398-duplicate-the-regular-login-flow-to-allow-Application-Password branch May 28, 2025 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Duplicate the regular login flow to allow application password first iteration #21914

Duplicate the regular login flow to allow application password first iteration #21914

Uh oh!

adalpari commented May 27, 2025 •

edited by nbradbury

Loading

Uh oh!

dangermattic commented May 27, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented May 27, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented May 27, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

nbradbury left a comment

Uh oh!

adalpari commented May 28, 2025

Uh oh!

sonarqubecloud bot commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Duplicate the regular login flow to allow application password first iteration #21914

Duplicate the regular login flow to allow application password first iteration #21914

Uh oh!

Conversation

adalpari commented May 27, 2025 • edited by nbradbury Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

dangermattic commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

nbradbury left a comment

Choose a reason for hiding this comment

Uh oh!

adalpari commented May 28, 2025

Uh oh!

sonarqubecloud bot commented May 28, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

adalpari commented May 27, 2025 •

edited by nbradbury

Loading

dangermattic commented May 27, 2025 •

edited

Loading

wpmobilebot commented May 27, 2025 •

edited

Loading

wpmobilebot commented May 27, 2025 •

edited

Loading

codecov bot commented May 27, 2025 •

edited

Loading