-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Simplify GutenbergKit content change listener #21663
base: trunk
Are you sure you want to change the base?
Conversation
Align the content change listener approach with that of Aztec and Gutenberg Mobile. The previous approach appeared to be unnecessary divergence.
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:v0.0.5
+| \--- org.wordpress.gutenbergkit:android:72-7ead6902b79992590645940da583caf0dae65ffc
-\--- org.wordpress.gutenbergkit:android:v0.0.5 (*)
+\--- org.wordpress.gutenbergkit:android:72-7ead6902b79992590645940da583caf0dae65ffc (*) |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21663 +/- ##
=======================================
Coverage 39.42% 39.42%
=======================================
Files 2122 2122
Lines 99558 99558
Branches 15317 15317
=======================================
Hits 39247 39247
Misses 56832 56832
Partials 3479 3479 ☔ View full report in Codecov by Sentry. |
Align the content change listener approach with that of Aztec and
Gutenberg Mobile. The previous approach appeared to be unnecessary
divergence.
Related: wordpress-mobile/GutenbergKit#72
To Test:
1: Content changes mark the post as unsaved
2: Content changes persist via auto-save
Regression Notes
Regressions in the Aztec and Gutenberg Mobile editors.
Manually tested the editors.
Deemed unnecessary for the experimental editor.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):