Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nullability Annotations to Java Classes] Use Updated and Null Proof CommentModel Class (breaking) #19389

Merged
merged 6 commits into from
Oct 19, 2023
Merged

[Nullability Annotations to Java Classes] Use Updated and Null Proof CommentModel Class (breaking) #19389

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab1afaa
Build: Update fluxc version to pr hash (#2870)
ParaskP7 Oct 16, 2023
98f9f11
Test: Update get likes use case test to updated on cmt likes changed
ParaskP7 Oct 16, 2023
e4bb43e
Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-Android…
ParaskP7 Oct 18, 2023
e1a6a97
Build: Update fluxc version to pr hash (#2870)
ParaskP7 Oct 18, 2023
5b890d4
Merge branch 'trunk' into analysis/use-updated-and-null-proff-comment…
ParaskP7 Oct 18, 2023
1a3ee3d
Build: Update fluxc version to trunk hash (#2870)
ParaskP7 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions WordPress/src/test/java/org/wordpress/android/ui/engagement/usecases/GetLikesUseCaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,9 +343,9 @@ class GetLikesUseCaseTest : BaseUnitTest() {
OnCommentLikesChanged(
siteId,
commentId,
false
false,
FETCHED_COMMENT_LIKES
).apply {
causeOfChange = FETCHED_COMMENT_LIKES
error = CommentError(
CommentErrorType.AUTHORIZATION_REQUIRED,
"Error occurred"
Expand Down Expand Up @@ -387,9 +387,9 @@ class GetLikesUseCaseTest : BaseUnitTest() {
OnCommentLikesChanged(
siteId,
commentId,
false
false,
FETCHED_COMMENT_LIKES
).apply {
causeOfChange = FETCHED_COMMENT_LIKES
error = CommentError(
CommentErrorType.AUTHORIZATION_REQUIRED,
errorMessage
Expand Down Expand Up @@ -431,9 +431,9 @@ class GetLikesUseCaseTest : BaseUnitTest() {
OnCommentLikesChanged(
siteId,
commentId,
false
false,
FETCHED_COMMENT_LIKES
).apply {
causeOfChange = FETCHED_COMMENT_LIKES
error = CommentError(
CommentErrorType.AUTHORIZATION_REQUIRED,
errorMessage
Expand Down Expand Up @@ -476,9 +476,9 @@ class GetLikesUseCaseTest : BaseUnitTest() {
OnCommentLikesChanged(
siteId,
commentId,
false
false,
FETCHED_COMMENT_LIKES
).apply {
causeOfChange = FETCHED_COMMENT_LIKES
commentLikes = likeData
}
)
Expand Down Expand Up @@ -512,9 +512,9 @@ class GetLikesUseCaseTest : BaseUnitTest() {
OnCommentLikesChanged(
siteId,
commentId,
false
false,
FETCHED_COMMENT_LIKES
).apply {
causeOfChange = FETCHED_COMMENT_LIKES
commentLikes = likeData
}
)
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ext {
automatticTracksVersion = '3.3.0'
gutenbergMobileVersion = 'v1.106.0'
wordPressAztecVersion = 'v1.8.0'
wordPressFluxCVersion = 'trunk-21b9cb51949bff38713430b86c31e4620623dcf2'
wordPressFluxCVersion = '2870-a164dd020a556a647fe3e66e2e5bd64a4d64080f'
wordPressLoginVersion = '1.6.0'
wordPressPersistentEditTextVersion = '1.0.2'
wordPressUtilsVersion = '3.10.0'
Expand Down
Loading