Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back SamsungInputConnection #1068

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

danilo04
Copy link
Contributor

@danilo04 danilo04 commented Nov 13, 2023

Fix

This PR adds back the SamsungInputConnection which helps avoid errors such as the editor transforming photos to obj items in the text.

Test

Note: use a Samsung device with Android 13.

  1. Open the app using Samsung device with android 13 and Samsung keyboard.
  2. Type some text into the app.
  3. Confirm that nothing looks off - focus stays where it should be, image is present, styles are not being removed.
  4. Confirm that autocorrect is not working - type something like "I hav " (with the space at the end) and notice that hav is not changed into have.
  5. Switch to Gboard (or other keyboard).
  6. Confirm that autocorrect is working - type something like "I hav " (with the space at the end) and notice that hav IS changed into have.
  7. Change back to samsung keyboard and confirm that the autocorrect is still disabled.

Review

@planarvoid @khaykov

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@danilo04 danilo04 marked this pull request as ready for review November 13, 2023 14:12
@khaykov khaykov self-assigned this Nov 13, 2023
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danilo04 !

I see we keep outAttrs.inputType = outAttrs.inputType or InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS, which is a good idea. Hopefully both this and SamsungInputConnection will prevent issue from happening.

@khaykov khaykov merged commit d93ce9f into trunk Nov 13, 2023
2 checks passed
@khaykov khaykov deleted the fix/add-samsung-input-conn-back branch November 13, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants