-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#479 Translating tutorial to traditional Chinese #592
base: main
Are you sure you want to change the base?
#479 Translating tutorial to traditional Chinese #592
Conversation
Hi @helenwu95! Can you clarify what you mean above, about verifying content before line 323? You can see the file and it's contents in |
Hi! @amyjko Just to clarify, my current progress on the Traditional Chinese translation is up to line 323, and I’m hoping someone can check that I’ve translated every tutorial up to that point, in case I miss something in my last check. Also, I apologize for misusing the hash earlier. |
I think I'm still unsure what you mean. Are you asking someone else who can code review your traditional Chinese translations, to make sure they are good, or that you didn't miss any translations between line 1-323? (You can check the letter easily, by just looking for English in the lines, which is why I'm confused). |
What I mean is that I might need someone to check if I've missed any translations before line 323. In Visual Studio, while I only need to translate the dialogue, the character names and functions, and UI settings are in English and often mixed in with the dialogue, which makes it easy to overlook something. Although I've checked everything twice before submitting, it would be helpful to have someone else review it before merging into the main branch. I will also do a comprehensive check of the translated sections in the end of this quarter, so everything should be fine. |
And I just found that there are some parts I didn't translate in Chapter 1, which are the "miss in first chapter (1)." I hope there won’t be any more oversights like that. |
Thanks for the clarification. When I look at lines 1-323, the main content that's not translated is code. It's still using all English names, but should be using Chinese names. |
…al_chinese_translation
… of https://github.com/helenwu95/wordplay into issue-wordplaydev#479]-traditional_chinese_translation
Context
The translation of traditional Chinese
Verification
Need another person to check if there is any content that hasn't translated into traditional Chinese before line 323.