[Feature] - 프로덕션 모니터링 구축 #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 30 files 30 suites 8s ⏱️ Results for commit 5c257ff. ♻️ This comment has been updated with latest results. |
nak-honest
commented
Dec 7, 2024
Comment on lines
14
to
19
| public static void main(String[] args) { | ||
| SpringApplication.run(TourootApplication.class, args); | ||
| new SpringApplicationBuilder() | ||
| .environment(new StandardEncryptableEnvironment()) | ||
| .sources(TourootApplication.class).run(args); | ||
| } | ||
| } |
There was a problem hiding this comment.
logback-spring.xml에서 jasypt 로 암호화 한 loki.loki-url 을 복호화 하지 못하는 문제가 있었습니다.
로깅은 스프링 부팅 초기에 매우 일찍 구성되기 때문에,
일반적인 설정으로는 jasypt로 복호화 된 값을 읽어오지 못한다고 합니다.
따라서 jasypt docs 에서 설명한 대로 스프링 초기화 동작을 위와 같이 재정의 하였습니다.
eunjungL
requested changes
Dec 8, 2024
| @@ -194,3 +194,5 @@ cloud: | |||
| image-base-uri: https://touroot.kr/ | |||
| origin-storage-path: touroot/ | |||
|
|
|||
| loki: | |||
| loki-url: ENC(FHJkwYBoGIuSifQd/92GjnWRS1nvcil2CPFCcWbTicu4rMe/gyFRYzQeqAMCyPkr) | |||
There was a problem hiding this comment.
저희 DEV profile의 loki-url은 평문 상태인데 이 부분도 암호화가 필요할까요~?
만약 필요하다면 확인 한 번 부탁드림다 🙇
There was a problem hiding this comment.
http://loki:3100/loki/api/v1/push 는 IP 주소가 노출되지 않아서 괜찮을 것 같아욥!
하지만 숨겨서 나쁠거 없으니 숨겨보도록 하겠습니다!!
Co-authored-by: eunjungL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
🙈 참고 사항