Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] - prod 프로필 SSL 인증서 제거 #497

Merged
merged 4 commits into from
Oct 8, 2024
Merged

[Feature] - prod 프로필 SSL 인증서 제거 #497

merged 4 commits into from
Oct 8, 2024

Conversation

eunjungL
Copy link
Contributor

@eunjungL eunjungL commented Oct 4, 2024

✅ 작업 내용

  • prod 프로필 SSL 인증서 제거
  • Github actions prod pipeline에서 ssl 인증서 생성 부분 제거

🙈 참고 사항

  • production 배포될 떄 ELB에서 대상 그룹 포트 변경해주는거 잊어버리면 안됩니다.

@eunjungL eunjungL self-assigned this Oct 4, 2024
@eunjungL eunjungL added the BE label Oct 4, 2024
@eunjungL eunjungL added this to the sprint 6 milestone Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Test Results

 31 files   31 suites   8s ⏱️
266 tests 266 ✅ 0 💤 0 ❌
278 runs  278 ✅ 0 💤 0 ❌

Results for commit 8b0dcb5.

♻️ This comment has been updated with latest results.

@eunjungL eunjungL linked an issue Oct 4, 2024 that may be closed by this pull request
[Feature] - prod 프로필 SSL 인증서 제거 #438
Closed
3 tasks
nak-honest
nak-honest approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@nak-honest nak-honest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다!
LGTM 드립니다!!

아직 무중단 배포까지 구현되지는 않았으니, ELB에 먼저 달고 배포하는 것이 좋을 것 같네요!

Libienz
Libienz approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Libienz Libienz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prod 배포되면 ELB와 EC2의 포트 수정해야게꾼요!

slimsha2dy
slimsha2dy approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@slimsha2dy slimsha2dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 입니다!

@eunjungL eunjungL merged commit ab39a4d into develop/be Oct 8, 2024
3 checks passed
@eunjungL eunjungL deleted the feature/be/#438 branch October 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Libienz Libienz Libienz approved these changes

@nak-honest nak-honest nak-honest approved these changes

@slimsha2dy slimsha2dy slimsha2dy approved these changes

@hangillee hangillee Awaiting requested review from hangillee

Assignees

@eunjungL eunjungL

Labels
BE
Projects
2024-touroot
Status: Done
Milestone
sprint 6
Development

Successfully merging this pull request may close these issues.

[Feature] - prod 프로필 SSL 인증서 제거
4 participants
@eunjungL @Libienz @nak-honest @slimsha2dy