Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] - 여행기 수정 시 썸네일을 임시 저장소에만 저장하는 버그 수정 #493

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[Fix] - 여행기 수정 시 썸네일을 임시 저장소에만 저장하는 버그 수정 #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/src/main/java/kr/touroot/travelogue/service/TravelogueService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
import kr.touroot.member.domain.Member;
import kr.touroot.travelogue.domain.Travelogue;
import kr.touroot.travelogue.domain.TravelogueFilterCondition;
import kr.touroot.travelogue.dto.request.TravelogueRequest;
import kr.touroot.travelogue.domain.search.SearchCondition;
import kr.touroot.travelogue.domain.search.SearchType;
import kr.touroot.travelogue.dto.request.TravelogueRequest;
import kr.touroot.travelogue.dto.request.TravelogueSearchRequest;
import kr.touroot.travelogue.repository.TravelogueRepository;
import kr.touroot.travelogue.repository.query.TravelogueQueryRepository;
Expand Down Expand Up @@ -68,7 +68,8 @@ public Travelogue update(Long id, Member author, TravelogueRequest request) {
.orElseThrow(() -> new BadRequestException("존재하지 않는 여행기입니다."));
validateAuthor(travelogue, author);

travelogue.update(request.title(), request.thumbnail());
String url = s3Provider.copyImageToPermanentStorage(request.thumbnail());
travelogue.update(request.title(), url);

return travelogueRepository.save(travelogue);
}
Expand Down
3 changes: 3 additions & 0 deletions backend/src/test/java/kr/touroot/travelogue/controller/TravelogueControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,9 @@ void findTraveloguesByKeywordWithoutSearchType() {
@DisplayName("여행기를 수정한다.")
@Test
void updateTravelogue() throws JsonProcessingException {
Mockito.when(s3Provider.copyImageToPermanentStorage(any(String.class)))
.thenReturn(TravelogueResponseFixture.getUpdatedTravelogueResponse().thumbnail());

Travelogue travelogue = testHelper.initTravelogueTestData(member);

List<TravelogueDayRequest> days = getUpdateTravelogueDayRequests();
Expand Down
5 changes: 5 additions & 0 deletions backend/src/test/java/kr/touroot/travelogue/service/TravelogueFacadeServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.when;

import java.util.List;
Expand Down Expand Up @@ -30,6 +31,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.mock.mockito.MockBean;
import org.springframework.context.annotation.Import;
Expand Down Expand Up @@ -204,6 +206,9 @@ void findTraveloguesByAuthorNicknameKeyword() {
@DisplayName("여행기를 수정할 수 있다.")
@Test
void updateTravelogue() {
Mockito.when(s3Provider.copyImageToPermanentStorage(any(String.class)))
.thenReturn(TravelogueResponseFixture.getUpdatedTravelogueResponse().thumbnail());

List<TravelogueDayRequest> days = getUpdateTravelogueDayRequests();
saveImages(days);

Expand Down
Loading