Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] - 여행기 응답 DTO 속성 이름 변경 #103

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[Refactor] - 여행기 응답 DTO 속성 이름 변경 #103

merged 1 commit into from
Jul 24, 2024

Conversation

hangillee
Copy link

✅ 작업 내용

  • 프론트엔드 파트의 요청에 맞춰 Location 속성의 이름을 Position으로 변경

🙈 참고 사항

@hangillee hangillee added the BE label Jul 24, 2024
@hangillee hangillee added this to the sprint 2 milestone Jul 24, 2024
@hangillee hangillee self-assigned this Jul 24, 2024
Libienz
Libienz approved these changes Jul 24, 2024
View reviewed changes
Copy link

@Libienz Libienz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L G T M

@github-actions GitHub Actions
Copy link

Test Results

 9 files   9 suites   3s ⏱️
29 tests 29 ✅ 0 💤 0 ❌
30 runs  30 ✅ 0 💤 0 ❌

Results for commit 610fff1.

@hangillee hangillee linked an issue Jul 24, 2024 that may be closed by this pull request
[Refactor] - 여행기 응답 DTO 속성 이름 변경 #101
Closed
1 task
nak-honest
nak-honest approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@nak-honest nak-honest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 바로 박습니다.
감사합니다 리건 선생님.

@hangillee hangillee merged commit 8ef1bbd into develop/be Jul 24, 2024
3 checks passed
@hangillee hangillee deleted the feature/be/#101 branch July 24, 2024 08:17
@hangillee hangillee restored the feature/be/#101 branch July 24, 2024 08:38
@slimsha2dy slimsha2dy deleted the feature/be/#101 branch July 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Libienz Libienz Libienz approved these changes

@nak-honest nak-honest nak-honest approved these changes

@eunjungL eunjungL Awaiting requested review from eunjungL

@slimsha2dy slimsha2dy Awaiting requested review from slimsha2dy

Assignees

@hangillee hangillee

Labels
BE
Projects
2024-touroot
Status: Done
Milestone
sprint 2
Development

Successfully merging this pull request may close these issues.

[Refactor] - 여행기 응답 DTO 속성 이름 변경
3 participants
@hangillee @Libienz @nak-honest