refactor: 오버로딩 제거 -> 메서드 시그니처에 명세 상세화

woowacourse-teams · Oct 9, 2024 · 99f67be · 99f67be
1 parent d079652
commit 99f67be
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/backend/src/main/java/kr/touroot/travelogue/controller/TravelogueController.java b/backend/src/main/java/kr/touroot/travelogue/controller/TravelogueController.java
@@ -103,7 +103,7 @@ public ResponseEntity<TravelogueLikeResponse> likeTravelogue(@PathVariable Long
     })
     @GetMapping("/{id}")
     public ResponseEntity<TravelogueResponse> findTravelogue(@PathVariable Long id) {
-        return ResponseEntity.ok(travelogueFacadeService.findTravelogueById(id));
+        return ResponseEntity.ok(travelogueFacadeService.findTravelogueByIdForGuest(id));
     }
 
     @Operation(summary = "여행기 상세 조회")
@@ -120,7 +120,7 @@ public ResponseEntity<TravelogueResponse> findTravelogue(@PathVariable Long id)
     })
     @GetMapping(value = "/{id}", headers = {HttpHeaders.AUTHORIZATION})
     public ResponseEntity<TravelogueResponse> findTravelogue(@PathVariable Long id, MemberAuth member) {
-        return ResponseEntity.ok(travelogueFacadeService.findTravelogueById(id, member));
+        return ResponseEntity.ok(travelogueFacadeService.findTravelogueByIdForAuthenticated(id, member));
     }
 
     @Operation(summary = "여행기 메인 페이지 조회")

diff --git a/backend/src/main/java/kr/touroot/travelogue/service/TravelogueFacadeService.java b/backend/src/main/java/kr/touroot/travelogue/service/TravelogueFacadeService.java
@@ -39,15 +39,15 @@ public TravelogueCreateResponse createTravelogue(MemberAuth member, TravelogueRe
     }
 
     @Transactional(readOnly = true)
-    public TravelogueResponse findTravelogueById(Long id) {
+    public TravelogueResponse findTravelogueByIdForGuest(Long id) {
         Travelogue travelogue = travelogueService.getTravelogueById(id);
         List<TravelogueTag> travelogueTags = travelogueTagService.readTagByTravelogue(travelogue);
 
         return TravelogueResponse.createResponseForGuest(travelogue, travelogueTags);
     }
 
     @Transactional(readOnly = true)
-    public TravelogueResponse findTravelogueById(Long id, MemberAuth member) {
+    public TravelogueResponse findTravelogueByIdForAuthenticated(Long id, MemberAuth member) {
         Member accessor = memberService.getMemberById(member.memberId());
         Travelogue travelogue = travelogueService.getTravelogueById(id);
         List<TravelogueTag> travelogueTags = travelogueTagService.readTagByTravelogue(travelogue);

diff --git a/backend/src/test/java/kr/touroot/travelogue/service/TravelogueFacadeServiceTest.java b/backend/src/test/java/kr/touroot/travelogue/service/TravelogueFacadeServiceTest.java
@@ -129,7 +129,7 @@ void likeTravelogueWithNotExist() {
     void findTravelogueById() {
         testHelper.initTravelogueTestData();
 
-        assertThat(service.findTravelogueById(1L))
+        assertThat(service.findTravelogueByIdForGuest(1L))
                 .isEqualTo(TravelogueResponseFixture.getTravelogueResponse());
     }
 
@@ -139,7 +139,7 @@ void findTravelogueByIdAndLiker() {
         Member liker = testHelper.initKakaoMemberTestData();
         Long travelogueId = testHelper.initTravelogueTestDataWithLike(liker).getId();
 
-        assertThat(service.findTravelogueById(travelogueId, new MemberAuth(liker.getId())))
+        assertThat(service.findTravelogueByIdForAuthenticated(travelogueId, new MemberAuth(liker.getId())))
                 .isEqualTo(TravelogueResponseFixture.getTravelogueResponseWithLike());
     }
 
@@ -262,7 +262,7 @@ void deleteById() {
         MemberAuth memberAuth = new MemberAuth(1L);
         service.deleteTravelogueById(1L, memberAuth);
 
-        assertThatThrownBy(() -> service.findTravelogueById(1L))
+        assertThatThrownBy(() -> service.findTravelogueByIdForGuest(1L))
                 .isInstanceOf(BadRequestException.class)
                 .hasMessage("존재하지 않는 여행기입니다.");
     }