-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] feat: 리뷰 폼 응답 재구현 #295
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
2ea69e6
feat: TemplateController 추가 및 리뷰 템플릿 응답 기능 구현
Kimprodp c424c06
feat: 리뷰 템플릿 응답을 위한 dto 생성
Kimprodp 5abbf92
refactor: 에러 응답 메세지 변경
Kimprodp 8d10101
refactor: onSelectedOptionId 타입 변경
Kimprodp d532c2b
refactor: 도메인 id 제외 생성자 추가
Kimprodp 8cdaabe
feat: TemplateService 추가 및 기본 템플릿 응답 기능 추가
Kimprodp 9039ec8
feat: TemplateMapper 구현
Kimprodp d6f708f
refactor: mapping url 중복으로 인한 context 로딩 에러 해결을 위해 임시적으로 url 경로 변경
Kimprodp 9c50413
refactor: 로깅 레벨 warn으로 변경
Kimprodp fa0ae42
refactor: 질문에 옵션 그룹이 없을 경우 null을 사용하도록 변경
Kimprodp 1811deb
refactor: id 리스트를 즉시 로딩할 수 있도록 변경
Kimprodp f2edd17
refactor: 메서드명 변경
Kimprodp 2c93220
test: 테스트 추가
Kimprodp bb2245c
test: DatabaseCleaner에서 CollectionTable로 생성된 테이블 초기화 하도록 변경
Kimprodp 040cbea
refactor: Transactional readOnly 설정
Kimprodp 274d8d3
refactor: 컨트롤러 요청 경로 변경
Kimprodp 31999b1
refactor: response에서 null 가능한 필드 명시
Kimprodp de0c64d
style: 오타 수정
Kimprodp f6c309c
refactor: Question2 hasGuideline 메서드에서 guideline이 null 인 경우도 추가
Kimprodp f7b1ec3
refactor: 기본 사용 템플릿을 찾을 수 없는 경우에 대한 예외명과 로그 메세지 수정
Kimprodp 207eccc
refactor: 옵션 그룹에 옵션 아이템이 없는 경우에 대한 예외명 수정
Kimprodp fef29f6
refactor: SectionNotFoundException의 로그 레벨 수정 (info -> warn)
Kimprodp bc28681
refactor: 사용하지 않는 메서드 삭제
Kimprodp d26b268
test: 가이드라인이 제공되지 않는 경우 테스트 추가
Kimprodp 3092be1
test: 옵션 그룹에 없는 질문이 없는 경우 테스트 추가
Kimprodp 892c73b
test: 섹션의 선택된 옵션이 필요없는 경우 테스트 추가
Kimprodp be6b8d5
refactor: long 타입 변경
Kimprodp d5c3b3d
Merge remote-tracking branch 'refs/remotes/origin/develop' into be/fe…
Kimprodp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
backend/src/main/java/reviewme/template/dto/response/OptionGroupResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package reviewme.template.dto.response; | ||
|
||
import java.util.List; | ||
|
||
public record OptionGroupResponse( | ||
|
||
long optionGroupId, | ||
int minCount, | ||
int maxCount, | ||
List<OptionItemResponse> options | ||
) { | ||
} |
8 changes: 8 additions & 0 deletions
8
backend/src/main/java/reviewme/template/dto/response/OptionItemResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package reviewme.template.dto.response; | ||
|
||
public record OptionItemResponse( | ||
|
||
long optionId, | ||
String content | ||
) { | ||
} |
13 changes: 13 additions & 0 deletions
13
backend/src/main/java/reviewme/template/dto/response/QuestionResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package reviewme.template.dto.response; | ||
|
||
public record QuestionResponse( | ||
|
||
long questionId, | ||
boolean required, | ||
String content, | ||
String questionType, | ||
OptionGroupResponse optionGroup, | ||
boolean hasGuideline, | ||
String guideline | ||
) { | ||
} |
13 changes: 13 additions & 0 deletions
13
backend/src/main/java/reviewme/template/dto/response/SectionResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package reviewme.template.dto.response; | ||
|
||
import java.util.List; | ||
|
||
public record SectionResponse( | ||
|
||
long sectionId, | ||
String visible, | ||
Integer onSelectedOptionId, | ||
String header, | ||
List<QuestionResponse> questions | ||
) { | ||
} |
12 changes: 12 additions & 0 deletions
12
backend/src/main/java/reviewme/template/dto/response/TemplateResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package reviewme.template.dto.response; | ||
|
||
import java.util.List; | ||
|
||
public record TemplateResponse( | ||
|
||
long formId, | ||
String revieweeName, | ||
String projectName, | ||
List<SectionResponse> sections | ||
) { | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null할 수 있는건 response단에서
@Nullable
명시해주는 건 어떤가요 ?