Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat: 내가 받은 리뷰 보기 기능 구현 #109

Merged
merged 24 commits into from
Jul 25, 2024
Merged

[BE] feat: 내가 받은 리뷰 보기 기능 구현 #109

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f522fd7
refactor: contains 작동을 위한 EqualsAndHashcode 추가
nayonsoso Jul 25, 2024
85ddfd2
fix: lazyInitialization 해결
nayonsoso Jul 25, 2024
a0ab043
feat: 질문 레포지토리 생성
nayonsoso Jul 25, 2024
b08db88
feat: 내가 받은 리뷰 응답 생성
nayonsoso Jul 25, 2024
4f18dda
refactor: 리뷰 항목과 질문의 연관관계 변경 및 답변 최대 글자수 DB에 반영
nayonsoso Jul 25, 2024
65a7917
refactor: 리뷰에 리뷰그룹 초기화 부분 추가
nayonsoso Jul 25, 2024
a8f2528
feat: 내가 받은 리뷰 조회 기능 구현
nayonsoso Jul 25, 2024
022910c
feat: 받은 리뷰가 없을 때의 응답 추가
nayonsoso Jul 25, 2024
453d1f4
refactor: dto 설명 추가
nayonsoso Jul 25, 2024
92ea554
refactor: dto 설명 수정
nayonsoso Jul 25, 2024
f2e1a0d
refactor: 인자 형식 수정, 개행 수정
nayonsoso Jul 25, 2024
bf00a66
refactor: transactional 어노테이션 추가
nayonsoso Jul 25, 2024
aa87cbd
refactor: 내가 받은 리뷰 조회할 때Page객체 말고 List로 받아오도록 수정
nayonsoso Jul 25, 2024
4a491fd
refactor: 미리보기 만드는 기능 도메인 안으로 이동
nayonsoso Jul 25, 2024
6fcbc6d
test: 테스트 코드 개선
nayonsoso Jul 25, 2024
010db8e
refactor: 마지막으로 본 리뷰ID가 없는 로직에 대해 수정
nayonsoso Jul 25, 2024
3a229bb
docs: 스웨거 데코레이션 적용
nayonsoso Jul 25, 2024
412523e
refactor: lastReviewId가 null 이어도 가장 최신 리뷰를 찾을 수 있도록 수정
nayonsoso Jul 25, 2024
1499f37
Merge remote-tracking branch 'refs/remotes/origin/develop' into 107-g…
donghoony Jul 25, 2024
bdc847b
Merge remote-tracking branch 'refs/remotes/origin/develop' into 107-g…
donghoony Jul 25, 2024
af8cf09
Merge remote-tracking branch 'origin/107-get-my-received-review' into…
donghoony Jul 25, 2024
1fb6465
refactor: eqaulsAndHashCode 재정의
nayonsoso Jul 25, 2024
c8e3cbe
refactor: eqaulsAndHashCode 재재정의
nayonsoso Jul 25, 2024
065f752
refactor: API Docs 반영
donghoony Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions backend/src/main/java/reviewme/review/domain/ReviewContent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import jakarta.persistence.Id;
import jakarta.persistence.JoinColumn;
import jakarta.persistence.ManyToOne;
import jakarta.persistence.OneToOne;
import jakarta.persistence.Table;
import lombok.AccessLevel;
import lombok.Getter;
Expand All @@ -31,11 +30,11 @@ public class ReviewContent {
@JoinColumn(name = "review_id", nullable = false)
private Review review;

@OneToOne
@ManyToOne
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요구사항대로 잘 되었네요 👍🏻

@JoinColumn(name = "question_id", nullable = false)
private Question question;

@Column(name = "answer", nullable = false)
@Column(name = "answer", nullable = false, length = MAX_ANSWER_LENGTH)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB에 글자수 조건 반영 좋네요!
(이 코드 관련한 건 아니지만 새삼 다른 곳에도 했나 생각해봤는데 안되어있는 것 같아서, 이 부분도 맞춰줘야하겠다 싶어요. 아래 예시)

@Entity
public class ReviewerGroup {

    @Column(name = "description", nullable = false)
    private String description;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉스 그런데 제가 하면 혹시라도 conflict 날까봐 리팩터링 목록에 넣어두겠습니다!

#112

private String answer;

public ReviewContent(Review review, Question question, String answer) {
Expand Down