Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat: 내가 받은 리뷰 보기 기능 구현 #109

Merged
merged 24 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f522fd7
refactor: contains 작동을 위한 EqualsAndHashcode 추가
nayonsoso Jul 25, 2024
85ddfd2
fix: lazyInitialization 해결
nayonsoso Jul 25, 2024
a0ab043
feat: 질문 레포지토리 생성
nayonsoso Jul 25, 2024
b08db88
feat: 내가 받은 리뷰 응답 생성
nayonsoso Jul 25, 2024
4f18dda
refactor: 리뷰 항목과 질문의 연관관계 변경 및 답변 최대 글자수 DB에 반영
nayonsoso Jul 25, 2024
65a7917
refactor: 리뷰에 리뷰그룹 초기화 부분 추가
nayonsoso Jul 25, 2024
a8f2528
feat: 내가 받은 리뷰 조회 기능 구현
nayonsoso Jul 25, 2024
022910c
feat: 받은 리뷰가 없을 때의 응답 추가
nayonsoso Jul 25, 2024
453d1f4
refactor: dto 설명 추가
nayonsoso Jul 25, 2024
92ea554
refactor: dto 설명 수정
nayonsoso Jul 25, 2024
f2e1a0d
refactor: 인자 형식 수정, 개행 수정
nayonsoso Jul 25, 2024
bf00a66
refactor: transactional 어노테이션 추가
nayonsoso Jul 25, 2024
aa87cbd
refactor: 내가 받은 리뷰 조회할 때Page객체 말고 List로 받아오도록 수정
nayonsoso Jul 25, 2024
4a491fd
refactor: 미리보기 만드는 기능 도메인 안으로 이동
nayonsoso Jul 25, 2024
6fcbc6d
test: 테스트 코드 개선
nayonsoso Jul 25, 2024
010db8e
refactor: 마지막으로 본 리뷰ID가 없는 로직에 대해 수정
nayonsoso Jul 25, 2024
3a229bb
docs: 스웨거 데코레이션 적용
nayonsoso Jul 25, 2024
412523e
refactor: lastReviewId가 null 이어도 가장 최신 리뷰를 찾을 수 있도록 수정
nayonsoso Jul 25, 2024
1499f37
Merge remote-tracking branch 'refs/remotes/origin/develop' into 107-g…
donghoony Jul 25, 2024
bdc847b
Merge remote-tracking branch 'refs/remotes/origin/develop' into 107-g…
donghoony Jul 25, 2024
af8cf09
Merge remote-tracking branch 'origin/107-get-my-received-review' into…
donghoony Jul 25, 2024
1fb6465
refactor: eqaulsAndHashCode 재정의
nayonsoso Jul 25, 2024
c8e3cbe
refactor: eqaulsAndHashCode 재재정의
nayonsoso Jul 25, 2024
065f752
refactor: API Docs 반영
donghoony Jul 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package reviewme.review.dto.response;

import io.swagger.v3.oas.annotations.media.Schema;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위쪽에 어떤 응답인지 @Schema 달아주세요~!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 속성에만 추가하고, dto 자체에는 안달아줬네요 😱
추가하고 푸쉬했습니다!

public record ReceivedReviewKeywordsResponse(

@Schema(description = "키워드 아이디")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 곳에서는 아이디를 "ID"로 표기했던 것 같은데, "아이디" 또는 "ID"로 통일해야 할 것 같아요.

Copy link
Contributor Author

@nayonsoso nayonsoso Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
스크린샷 2024-07-25 오후 3 46 25

웁스 그렇네요!! 이슈 만들었습니다
#112

long id,

@Schema(description = "키워드 내용")
String content
) {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package reviewme.review.dto.response;

import io.swagger.v3.oas.annotations.media.Schema;
import java.time.LocalDate;
import java.util.List;

public record ReceivedReviewResponse(

@Schema(description = "리뷰 아이디")
long id,

@Schema(description = "공개 여부")
boolean isPublic,

@Schema(description = "리뷰 작성일")
LocalDate createdAt,

@Schema(description = "응답 내용 미리보기")
String contentPreview,

@Schema(description = "리뷰어 그룹 정보")
ReceivedReviewReviewerGroupResponse reviewerGroup,

@Schema(description = "키워드")
List<ReceivedReviewKeywordsResponse> keywords
) {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package reviewme.review.dto.response;

import io.swagger.v3.oas.annotations.media.Schema;

public record ReceivedReviewReviewerGroupResponse(

@Schema(description = "리뷰어 그룹 아이디")
long id,

@Schema(description = "리뷰어 그룹 이름")
String name,

@Schema(description = "리뷰어 그룹 썸네일 이미지 URL")
String thumbnailUrl
) {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package reviewme.review.dto.response;

import io.swagger.v3.oas.annotations.media.Schema;
import java.util.List;

public record ReceivedReviewsResponse(

@Schema(description = "응답 크기")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금 모호한 디스크립션이라고 느껴져요. 응답 개수가 더 나으려나요 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다 👍

long size,

@Schema(description = "마지막 리뷰 아이디")
long lastReviewId,

@Schema(description = "받은 리뷰 목록")
List<ReceivedReviewResponse> reviews
) {
}