-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] refactor: ReviewCard에서 강점 키워드를 표시하는 ReviewKeyword 컴포넌트 분리 및 불필요한 예시 제거 #1039
Merged
BadaHertz52
merged 16 commits into
develop
from
fe/refactor/1030-strength-keyword-component
Jan 7, 2025
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9ea0611
fix: 강점 키워드 데이터 서버 응답 형식과 통일
soosoo22 46488a1
feat: StrengthKeywordList 컴포넌트 생성
soosoo22 7ff2091
refactor: ReviewCard 폴더 위치 이동 및 디자인 수정
soosoo22 42bd98f
refactor: formattedCategories 함수 유틸로 분리 및 목록, 상세 페이지에 적용
soosoo22 3db5773
refactor: 작성일 표시 방식을 ReviewDate 컴포넌트를 사용하도록 변경
soosoo22 2078ac0
design: 상세 페이지 디자인 변경
soosoo22 679a8de
chore: 작성일 형식을 '-'에서 '.'으로 변경
soosoo22 330db3b
refactor: 배열을 처리하던 함수를 단일 문자열을 포맷팅하는 formatKeyword 함수로 변경
soosoo22 0a1fc8c
refactor: ReviewCard에서 강점 키워드를 표시하는 ReviewKeyword 컴포넌트 분리
soosoo22 5f81c4e
refactor: KeywordSection에서 MultipleChoiceAnswer 컴포넌트명으로 변경
soosoo22 70634cc
refactor: formatKeyword 함수에서 반환 타입을 명시하지 않도록 변경
soosoo22 27f0b9c
style: css 속성 정렬
soosoo22 8cf2414
refactor: QuestionAnswerSection을 질문과 답변(객관식/주관식) 구조로 변경
soosoo22 62eaf4c
refactor: MultilineTextViewer 상세 페이지 관련 컴포넌트로 폴더 위치 변경
soosoo22 33a44c4
refactor: 예시 포함 여부에 따라 포맷팅된 답변 또는 원본 답변 표시
soosoo22 541b890
refactor: MultilineTextViewer 컴포넌트 위치를 src/components/common/으로 복원
soosoo22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
frontend/src/components/common/MultilineTextViewer/styles.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,19 @@ | ||
import styled from '@emotion/styled'; | ||
|
||
export const MultilineTextContainer = styled.div` | ||
overflow-y: auto; | ||
|
||
box-sizing: border-box; | ||
width: 100%; | ||
height: 20rem; | ||
padding: 1rem 1.5rem; | ||
|
||
font-size: 1.6rem; | ||
line-height: 2.4rem; | ||
|
||
background-color: ${({ theme }) => theme.colors.lightGray}; | ||
`; | ||
|
||
export const MultilineText = styled.div` | ||
word-wrap: break-word; | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import formatKeyword from '@/utils/formatKeyword'; | ||
|
||
import * as S from './styles'; | ||
|
||
const ReviewKeyword = ({ content }: { content: string }) => { | ||
const formattedKeyword = formatKeyword(content); | ||
|
||
return <S.ReviewKeyword>{formattedKeyword}</S.ReviewKeyword>; | ||
}; | ||
|
||
export default ReviewKeyword; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import styled from '@emotion/styled'; | ||
|
||
export const ReviewKeyword = styled.li` | ||
padding: 0.5rem 2rem; | ||
|
||
font-weight: ${({ theme }) => theme.fontWeight.semibold}; | ||
color: ${({ theme }) => theme.colors.primary}; | ||
|
||
background-color: ${({ theme }) => theme.colors.lightPurple}; | ||
border-radius: 1.4rem; | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
목데이터와 실제 데이터가 같아졌네요! 헷갈렸는데 좋네요~~