[BE] refactor: 사용하지 않는 메서드 제거, 컨벤션 및 작은 리팩토링 (#206)

* refactor: date를 review가 제공하도록 수정 * style: 컨벤션 적용 * refactor: 사용하지 않는 메서드 제거 * refactor: 메서드명 통일 * style: 불필요한 개행 제거
woowacourse-teams · Aug 5, 2024 · a28494a · a28494a
1 parent 9668e97
commit a28494a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/backend/src/main/java/reviewme/global/GlobalExceptionHandler.java b/backend/src/main/java/reviewme/global/GlobalExceptionHandler.java
@@ -46,7 +46,6 @@ public ProblemDetail handleUnAuthorizedException(UnAuthorizedException ex) {
         return ProblemDetail.forStatusAndDetail(HttpStatus.UNAUTHORIZED, ex.getErrorMessage());
     }
 
-
     @ExceptionHandler(Exception.class)
     public ProblemDetail handleException(Exception ex) {
         log.error("An error occurred", ex);

diff --git a/backend/src/main/java/reviewme/review/controller/ReviewController.java b/backend/src/main/java/reviewme/review/controller/ReviewController.java
@@ -45,7 +45,8 @@ public ResponseEntity<ReviewSetupResponse> findReviewCreationSetup(@RequestParam
     }
 
     @GetMapping("/reviews/{id}")
-    public ResponseEntity<ReviewDetailResponse> findReceivedReviewDetail(@PathVariable long id, HttpServletRequest request) {
+    public ResponseEntity<ReviewDetailResponse> findReceivedReviewDetail(@PathVariable long id,
+                                                                         HttpServletRequest request) {
         String groupAccessCode = request.getHeader(GROUP_ACCESS_CODE_HEADER);
         ReviewDetailResponse response = reviewService.findReceivedReviewDetail(groupAccessCode, id);
         return ResponseEntity.ok(response);

diff --git a/backend/src/main/java/reviewme/review/domain/Review.java b/backend/src/main/java/reviewme/review/domain/Review.java
@@ -10,6 +10,7 @@
 import jakarta.persistence.JoinColumn;
 import jakarta.persistence.OneToMany;
 import jakarta.persistence.Table;
+import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.List;
 import lombok.AccessLevel;
@@ -42,7 +43,7 @@ public Review(long reviewGroupId, List<ReviewContent> reviewContents, LocalDateT
         this.createdAt = createdAt;
     }
 
-    public boolean isGroupIdEqualTo(long reviewGroupId) {
-        return this.reviewGroupId == reviewGroupId;
+    public LocalDate getCreatedDate() {
+        return createdAt.toLocalDate();
     }
 }
diff --git a/backend/src/main/java/reviewme/review/service/ReviewService.java b/backend/src/main/java/reviewme/review/service/ReviewService.java
@@ -129,7 +129,7 @@ private ReviewDetailResponse createReviewDetailResponse(Review review, ReviewGro
 
         return new ReviewDetailResponse(
                 review.getId(),
-                review.getCreatedAt().toLocalDate(),
+                review.getCreatedDate(),
                 reviewGroup.getProjectName(),
                 reviewGroup.getReviewee(),
                 reviewContents,
@@ -144,12 +144,12 @@ public ReceivedReviewsResponse findReceivedReviews(String groupAccessCode) {
         List<ReceivedReviewResponse> reviewResponses =
                 reviewRepository.findReceivedReviewsByGroupId(reviewGroup.getId())
                         .stream()
-                        .map(this::extractResponse)
+                        .map(this::createReceivedReviewResponse)
                         .toList();
         return new ReceivedReviewsResponse(reviewGroup.getReviewee(), reviewGroup.getProjectName(), reviewResponses);
     }
 
-    private ReceivedReviewResponse extractResponse(Review review) {
+    private ReceivedReviewResponse createReceivedReviewResponse(Review review) {
         List<ReceivedReviewKeywordsResponse> keywordsResponses =
                 reviewKeywordRepository.findAllByReviewId(review.getId())
                         .stream()

diff --git a/backend/src/main/java/reviewme/reviewgroup/controller/ReviewGroupController.java b/backend/src/main/java/reviewme/reviewgroup/controller/ReviewGroupController.java
@@ -17,7 +17,9 @@ public class ReviewGroupController {
     private final ReviewGroupService reviewGroupService;
 
     @PostMapping("/groups")
-    public ResponseEntity<ReviewGroupCreationResponse> createReviewGroup(@Valid @RequestBody ReviewGroupCreationRequest request) {
+    public ResponseEntity<ReviewGroupCreationResponse> createReviewGroup(
+            @Valid @RequestBody ReviewGroupCreationRequest request
+    ) {
         ReviewGroupCreationResponse response = reviewGroupService.createReviewGroup(request);
         return ResponseEntity.ok(response);
     }