refactor: notification을 타입계층으로 리팩터링

backend/src/main/java/com/ody/mate/service/MateService.java

@@ -55,14 +55,14 @@ public MateSaveResponseV2 saveAndSendNotifications(
         Mate mate = saveMateAndEta(mateSaveRequest, member, meeting);
 
         FcmTopic fcmTopic = new FcmTopic(meeting);
-        sendEntry(meeting, mate, fcmTopic);
+        sendEntry(mate, fcmTopic);
         notificationService.subscribeTopic(member.getDeviceToken(), fcmTopic);
         sendDepartureReminder(meeting, mate, fcmTopic);
         return MateSaveResponseV2.from(meeting);
     }
 
-    private void sendEntry(Meeting meeting, Mate mate, FcmTopic fcmTopic) {
-        Entry entry = new Entry(mate, meeting, fcmTopic);
+    private void sendEntry(Mate mate, FcmTopic fcmTopic) {
+        Entry entry = new Entry(mate, fcmTopic);
         notificationService.saveAndSchedule(entry.toNotification());
     }
 

backend/src/main/java/com/ody/notification/domain/Notification.java

@@ -61,7 +61,7 @@ public Notification(
     }
 
     public boolean isDepartureReminder() {
-        return this.type.isDepartureReminder();
+        return type.isDepartureReminder();
     }
 
     public boolean isStatusDismissed() {

backend/src/main/java/com/ody/notification/domain/types/AbstractNotification.java

@@ -6,26 +6,26 @@
 import com.ody.notification.domain.NotificationStatus;
 import com.ody.notification.domain.NotificationType;
 import java.time.LocalDateTime;
-import lombok.AllArgsConstructor;
 
-@AllArgsConstructor
 public abstract class AbstractNotification {
 
-    private final Long id;
     private final Mate mate;
     private final NotificationType type;
     private final LocalDateTime sendAt;
     private final NotificationStatus status;
     private final FcmTopic fcmTopic;
 
-    public AbstractNotification(
+    protected AbstractNotification(
             Mate mate,
-            NotificationType type,
             LocalDateTime sendAt,
             NotificationStatus status,
             FcmTopic fcmTopic
     ) {
-        this(null, mate, type, calculateSendAt(sendAt), status, fcmTopic);
+        this.mate = mate;
+        this.type = getType();
+        this.sendAt = calculateSendAt(sendAt);
+        this.status = status;
+        this.fcmTopic = fcmTopic;
     }
 
     private static LocalDateTime calculateSendAt(LocalDateTime sendAt) {
@@ -35,7 +35,9 @@ private static LocalDateTime calculateSendAt(LocalDateTime sendAt) {
         return sendAt;
     }
 
+    abstract NotificationType getType();
+
     public Notification toNotification() {
-        return new Notification(id, mate, type, sendAt, status, fcmTopic);
+        return new Notification(null, mate, type, sendAt, status, fcmTopic);
     }
 }

backend/src/main/java/com/ody/notification/domain/types/DepartureReminder.java

@@ -8,9 +8,12 @@
 
 public class DepartureReminder extends AbstractNotification {
 
-    private static final NotificationType type = NotificationType.DEPARTURE_REMINDER;
-
     public DepartureReminder(Mate mate, DepartureTime departureTime, FcmTopic fcmTopic) {
-        super(mate, type, departureTime.getValue(), NotificationStatus.PENDING, fcmTopic);
+        super(mate, departureTime.getValue(), NotificationStatus.PENDING, fcmTopic);
+    }
+
+    @Override
+    public NotificationType getType() {
+        return NotificationType.DEPARTURE_REMINDER;
     }
 }

backend/src/main/java/com/ody/notification/domain/types/Entry.java

@@ -1,18 +1,20 @@
 package com.ody.notification.domain.types;
 
 import com.ody.mate.domain.Mate;
-import com.ody.meeting.domain.Meeting;
 import com.ody.notification.domain.FcmTopic;
 import com.ody.notification.domain.NotificationStatus;
 import com.ody.notification.domain.NotificationType;
 import java.time.LocalDateTime;
 
 public class Entry extends AbstractNotification {
 
-    private static final NotificationType type = NotificationType.ENTRY;
+    public Entry(Mate mate, FcmTopic fcmTopic) {
+        super(mate, LocalDateTime.now(), NotificationStatus.DONE, fcmTopic);
+    }
 
-    public Entry(Mate mate, Meeting meeting, FcmTopic fcmTopic) {
-        super(mate, type, LocalDateTime.now(), NotificationStatus.DONE, fcmTopic);
+    @Override
+    public NotificationType getType() {
+        return NotificationType.ENTRY;
     }
 }
 

backend/src/main/java/com/ody/notification/domain/types/MateLeave.java

@@ -7,9 +7,12 @@
 
 public class MateLeave extends AbstractNotification {
 
-    private static final NotificationType type = NotificationType.LEAVE;
-
     public MateLeave(Mate mate) {
-        super(mate, type, LocalDateTime.now(), NotificationStatus.DONE, null);
+        super(mate, LocalDateTime.now(), NotificationStatus.DONE, null);
+    }
+
+    @Override
+    public NotificationType getType() {
+        return NotificationType.LEAVE;
     }
 }

backend/src/main/java/com/ody/notification/domain/types/MemberDeletion.java

@@ -7,9 +7,12 @@
 
 public class MemberDeletion extends AbstractNotification {
 
-    private static final NotificationType type = NotificationType.MEMBER_DELETION;
-
     public MemberDeletion(Mate mate) {
-        super(mate, type, LocalDateTime.now(), NotificationStatus.DONE, null);
+        super(mate, LocalDateTime.now(), NotificationStatus.DONE, null);
+    }
+
+    @Override
+    public NotificationType getType() {
+        return NotificationType.MEMBER_DELETION;
     }
 }

backend/src/main/java/com/ody/notification/domain/types/Nudge.java

@@ -7,9 +7,12 @@
 
 public class Nudge extends AbstractNotification {
 
-    private static final NotificationType type = NotificationType.NUDGE;
-
     public Nudge(Mate nudgeMate) {
-        super(nudgeMate, type, LocalDateTime.now(), NotificationStatus.DONE, null);
+        super(nudgeMate, LocalDateTime.now(), NotificationStatus.DONE, null);
+    }
+
+    @Override
+    public NotificationType getType() {
+        return NotificationType.NUDGE;
     }
 }

backend/src/test/java/com/ody/notification/domain/types/DepartureReminderTest.java

@@ -1,8 +1,6 @@
 package com.ody.notification.domain.types;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.eq;
 
 import com.ody.common.Fixture;
 import com.ody.mate.domain.Mate;
@@ -33,5 +31,4 @@ void sendImmediatelyIfDepartureTimeIsPast() {
 
         assertThat(actualSendTime).isEqualTo(now);
     }
-
 }