대시보드 내가 제출한 디스커션 구현 (issue #440) #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const commentDate = formatDateString(createdAt); | ||
|
|
||
| return ( | ||
| <S.CommentWrapper to={`/solutions/${solutionId}`}> | ||
| <S.CommentWrapper to={`/discussions/${contentId}`}> |
There was a problem hiding this comment.
MyComment가 공통으로 사용되는 컴포넌트라 Comment 클릭 시 이동하는 경로를 다르게 지정해야 할 것 같은데 어떻게 생각하실까요?!
There was a problem hiding this comment.
짚어주셔서 감사해용~ 타입을 props로 받아서 바꿔보았습니다!
frontend/src/hooks/queries/keys.ts
Outdated
| @@ -29,3 +29,8 @@ export const hashTagsKeys = { | |||
| export const userKeys = { | |||
| info: ['userInfo'], | |||
| }; | |||
|
|
|||
| export const DashboardKeys = { | |||
There was a problem hiding this comment.
camelCase로 작성해주시면 좋을 것 같습니다~
| const useDashboardDiscussionComment = () => { | ||
| return useSuspenseQuery({ | ||
| queryFn: getDashboardDiscussionComments, | ||
| queryKey: DashboardKeys.comments, |
There was a problem hiding this comment.
comments가 discussion, solution 두 종류로 나누어져서 query key도 두 종류가 있으면 좋을 것 같다는 생각이 드는데요..! ['comments', 'discussion'] 이렇게 하는 건 어떨까요??
There was a problem hiding this comment.
쿼리키 분리해보았는데 이렇게 말씀하신게 맞는지 확신이 서진 않네요..!
Comment on lines
+10
to
+36
| const NO_CONTENT_INFO = { | ||
| inProgress: { | ||
| route: ROUTES.missionList, | ||
| mainText: '진행 중인 미션이 없어요', | ||
| subText: '새로운 미션을 찾으러 가볼까요?', | ||
| buttonText: '미션 둘러보기', | ||
| }, | ||
| submitted: { | ||
| route: ROUTES.solutions, | ||
| mainText: '제출한 솔루션이 없어요', | ||
| subText: '참여할 수 있는 미션을 찾아보러 가볼까요?', | ||
| buttonText: '미션 둘러보기', | ||
| }, | ||
| comments: { | ||
| route: ROUTES.solutions, | ||
| mainText: '제출한 댓글이 없어요', | ||
| subText: '댓글을 달아볼까요?', | ||
| buttonText: '솔루션 둘러보기', | ||
| }, | ||
| dashboardDiscussion: { | ||
| route: '/discussion', | ||
| mainText: '제출한 디스커션이 없어요', | ||
| subText: '다른 사람들이 작성한 디스커션을 보러 가볼까요?', | ||
| buttonText: '디스커션 둘러보기', | ||
| }, | ||
| }; | ||
|
|
There was a problem hiding this comment.
와 이렇게 객체로 하니까 훨씬 깔끔해요!!!👍🏻👍🏻
|
백엔드 파일이 추가되어서 백엔드 CI가 돌아가지 않는 것 같은데...🧐 혹시 추가되어 있는 java 파일이 필요하지 않다면 지워보는 것은 어떨까요...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 요약
대시보드창에서 내가 작성한 디스커션과 디스커션 관련 댓글 기능을 구현합니다.
연관 이슈
참고
코드 리뷰에
RCA 룰을 적용할 시 참고해주세요.