refactor: 변경사항 반영

woowacourse-teams · Oct 23, 2024 · 8d3f46a · 8d3f46a
1 parent 23e6f2e
commit 8d3f46a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 11 deletions.
diff --git a/frontend/src/components/DiscussionSubmit/index.tsx b/frontend/src/components/DiscussionSubmit/index.tsx
@@ -43,7 +43,7 @@ export default function DiscussionSubmit() {
     discussionTitle,
     isDiscussionTitleError,
     isValidDiscussionTitle,
-    isValidDescription,
+    // isValidDescription,
     handleDiscussionTitle,
     handleMarkDownDescription,
     isDescriptionError,
@@ -123,7 +123,7 @@ export default function DiscussionSubmit() {
           />
           <DiscussionDescription
             value={description}
-            danger={isDescriptionError || !isValidDescription}
+            danger={isDescriptionError}
             dangerMessage={ERROR_MESSAGE.no_content}
             onChange={handleMarkDownDescription}
           />

diff --git a/frontend/src/hooks/useDiscussionTitle.ts b/frontend/src/hooks/useDiscussionTitle.ts
@@ -6,8 +6,7 @@ const MAX_DISCUSSION_TITLE_LENGTH = 50;
 const useDiscussionTitle = () => {
   const [discussionTitle, setDiscussionTitle] = useState('');
   const [isDiscussionTitleError, setIsDiscussionTitleError] = useState(false);
-  const isValidDiscussionTitle =
-    discussionTitle.length && discussionTitle.length < MAX_DISCUSSION_TITLE_LENGTH;
+  const isValidDiscussionTitle = discussionTitle.length < MAX_DISCUSSION_TITLE_LENGTH;
 
   const handleDiscussionTitle = (e: ChangeEvent<HTMLInputElement>) => {
     const value = e.target.value;

diff --git a/frontend/src/hooks/useSolutionTitle.ts b/frontend/src/hooks/useSolutionTitle.ts
@@ -7,8 +7,7 @@ const MAX_SOLUTION_TITLE_LENGTH = 50;
 const useSolutionTitle = () => {
   const [solutionTitle, setSolutionTitle] = useState('');
   const [isSolutionTitleError, setIsSolutionTitleError] = useState(false);
-  const isValidSolutionTitle =
-    solutionTitle.length && solutionTitle.length < MAX_SOLUTION_TITLE_LENGTH;
+  const isValidSolutionTitle = solutionTitle.length < MAX_SOLUTION_TITLE_LENGTH;
 
   const handleSolutionTitle = (e: ChangeEvent<HTMLInputElement>) => {
     const value = e.target.value;

diff --git a/frontend/src/hooks/useSubmitSolutionMutation.ts b/frontend/src/hooks/useSubmitSolutionMutation.ts
@@ -18,7 +18,11 @@ const useSubmitSolutionMutation = ({
 }: UseSubmissionMutationParams) => {
   const navigate = useNavigate();
 
-  const { mutate: submitSolutionMutation, isPending } = useSingleRequestMutation({
+  const {
+    mutate: submitSolutionMutation,
+    isPending,
+    isError: isSubmitSolutionError,
+  } = useSingleRequestMutation({
     mutationFn: postSolutionSubmit,
     onSuccess: ({ id }) => {
       onSuccessCallback();

diff --git a/frontend/src/pages/MissionSubmitPage.tsx b/frontend/src/pages/MissionSubmitPage.tsx
@@ -42,8 +42,8 @@ export default function MissionSubmitPage() {
     isDescriptionError,
     isSolutionTitleError,
     isSubmitSolutionError,
-    isValidUrl,
-    isValidDescription,
+    // isValidUrl,
+    // isValidDescription,
     isValidSolutionTitle,
     // isMatchedMissionName,
   } = useSubmitSolution({ missionId, missionName });
@@ -97,10 +97,10 @@ export default function MissionSubmitPage() {
             value={url}
             onChange={handleUrl}
             missionId={missionId}
-            danger={isUrlError || isSubmitSolutionError || !isValidUrl}
+            danger={isUrlError || isSubmitSolutionError}
           />
           <OneWord
-            danger={isDescriptionError || !isValidDescription}
+            danger={isDescriptionError}
             dangerMessage={ERROR_MESSAGE.no_content}
             value={description ?? ''}
             onChange={handleMarkDownDescription}