[FEAT] 다음 라운드 넘어가기 API #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PgmJun
approved these changes
Jul 25, 2024
Comment on lines
29
to
35
|
|
||
| @GetMapping("/balances/rooms/{roomId}/members") | ||
| public ResponseEntity<RoomMembersResponse> getAllBalanceGameRoomMember(@Positive @PathVariable Long roomId) { | ||
| RoomMembersResponse response = roomService.findAllRoomMember(roomId); | ||
|
|
||
| return ResponseEntity.ok(response); | ||
| } |
There was a problem hiding this comment.
의견) 이거 제가 ResponseEntity 사용 관련해서 정해진게 없을 때 구현했던 코드인데 혹시 ResponseEntity로 감싼 부분 제거해주실 수 있는지 간곡한 요청을 드립니다..
Comment on lines
77
to
78
| private RoomContent findCurrentRoomContent(Long roomId) { | ||
| Room room = roomRepository.getById(roomId); |
There was a problem hiding this comment.
질문) roomRepository에서 roomId로 이미 room을 찾아오는데 여기서 또 다시 조회하는 이유가 궁금합니다~!
이미 찾은 room만 받아도 되지않을까요?
Comment on lines
+32
to
+49
| @Test | ||
| void 마지막_라운드_일_경우_예외를_던진다() { | ||
| // given | ||
| Room room = new Room(); | ||
| goToFinalRound(room); | ||
|
|
||
| // when & then | ||
| assertThatThrownBy(() -> room.moveToNextRound()) | ||
| .isInstanceOf(BadRequestException.class) | ||
| .hasMessage("마지막 라운드입니다."); | ||
| } | ||
|
|
||
| private void goToFinalRound(Room room) { | ||
| for (int round = START_ROUND; round < TOTAL_ROUND; round++) { | ||
| room.moveToNextRound(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
의견) 이후에 Room의 total_round를 생성자를 통해 입력하게 되면 이 테스트는 터지게될 수도 있으니 주의가 필요할 것 같네요.
There was a problem hiding this comment.
아마도 지금 사용하는 생성자를 유지하지 않을까 싶어요. 결국에는 초기 방 생성시에는 TOTAL_ROUND의 기본 값이 필요할 테니까요. 그리고 updateTotalRound() 형식으로 바뀌어지지 않을까요?
미래를 생각하는 힘드니, 지금 이 형식은 유지하고, 나중에 값이 바뀔 수 있을 때 조금 다듬어야 겠네요;;
GIVEN53
approved these changes
Jul 26, 2024
RoomService, init.sql 및 일부 테스트 데이터 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closed #63
As-Is
다음 라운드 넘어가는 API 필요
To-Be
다음 라운드 넘어가는 API 구현
Check List
Test Screenshot
(Optional) Additional Description
RoomService에 생성한 로직이BalanceVoteService와 동일한 코드가 존재