feat-fe: 지원자 평가 목록에서 개별 평가 삭제 기능 추가 #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1736425223.963819 |
|
1736425232.229579 |
lurgi
reviewed
Jan 12, 2025
Comment on lines
21
to
25
| const { mutate: deleteEvaluation, isPending: isDeletePending } = evaluationMutations.useDeleteEvaluation({ | ||
| processId, | ||
| applicantId, | ||
| }); | ||
|
|
There was a problem hiding this comment.
기능상으로 큰 문제는 아니지만, 제안 하나 드리고 싶어요!
해당 mutation은 card에서 각각 실행되고, isPending 역시 카드당 각각 표시되는 것이 조금 더 적절하다 생각합니다!
즉 EvaluationCard에 해당하는 각각의 mutate가 생성되는 것이 적절할 것으로 생각되는데요,
evaluationMutations.useDeleteEvaluation 호출을 EvaluationCard내부에서 해주는 것은 어떨까요?
혹은 이렇게 구현된 이유가 있으신지 궁금하네요!
There was a problem hiding this comment.
모든 EvaluationCard 컴포넌트에 processId, applicantId 필드를 prop으로 내려주는 것이 다소 번거롭다고 생각했어요. 다만 관심사의 분리 측면에서는, 말씀대로 개별 평가에 대한 mutation 동작과 그 동작의 pending 상태는 해당 평가에 대응하는 컴포넌트(EvaluationCard)에서 처리하는 것이 더 적절해 보이네요. 아래 커밋으로 수정 반영했습니다. :)
Comment on lines
+38
to
+39
| queryClient.invalidateQueries({ queryKey: [QUERY_KEYS.EVALUATION, processId, applicantId] }); | ||
| queryClient.invalidateQueries({ queryKey: [QUERY_KEYS.DASHBOARD, dashboardId, applyFormId] }); |
lurgi
approved these changes
Jan 14, 2025
llqqssttyy
approved these changes
Jan 14, 2025
| @@ -0,0 +1,103 @@ | |||
| import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
EVAL_DELETE_01
목적
작업 세부사항
PR 리뷰시 참고사항
dialog로 구현된 지원자 정보 모달의 특성상, 현재는 모달이 toast 메시지를 가리는 상태입니다.div기반으로 수정되기 전까지는 해당 코드를 주석 처리하기로 했습니다.useEvaluationQuery,useEvaluationMutation코드들을src/hooks/evaluation.ts파일에 모두 병합시켰습니다.구현 화면
관련 이슈