refactor: toString 재정의 및 검증 로직 분리

woowacourse-teams · Dec 19, 2024 · eb60471 · eb60471
1 parent ea2380e
commit eb60471
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/backend/src/main/java/com/cruru/applicant/domain/Evaluation.java b/backend/src/main/java/com/cruru/applicant/domain/Evaluation.java
@@ -66,6 +66,18 @@ private boolean isOutOfRange(int score) {
         return score < MIN_SCORE || score > MAX_SCORE;
     }
 
+    public boolean isEvaluator(String evaluator) {
+        return this.evaluator.equals(evaluator);
+    }
+
+    public boolean isContent(String content) {
+        return this.content.equals(content);
+    }
+
+    public boolean isScore(int score) {
+        return this.score == score;
+    }
+
     @Override
     public boolean isAuthorizedBy(Member member) {
         return process.isAuthorizedBy(member);
@@ -92,6 +104,7 @@ public int hashCode() {
     public String toString() {
         return "Evaluation{" +
                 "id=" + id +
+                ", evaluator='" + evaluator + '\'' +
                 ", score=" + score +
                 ", content='" + content + '\'' +
                 ", process=" + process +

diff --git a/backend/src/main/java/com/cruru/applicant/service/EvaluationService.java b/backend/src/main/java/com/cruru/applicant/service/EvaluationService.java
@@ -57,9 +57,9 @@ public void update(EvaluationUpdateRequest request, Evaluation evaluation) {
 
     private boolean changeExists(EvaluationUpdateRequest request, Evaluation evaluation) {
         return !(
-                evaluation.getContent().equals(request.content())
-                        && evaluation.getScore().equals(request.score())
-                        && evaluation.getEvaluator().equals(request.evaluator())
+                evaluation.isContent(request.content())
+                        && evaluation.isScore(request.score())
+                        && evaluation.isEvaluator(request.evaluator())
         );
     }