문의하기 글자수 제한 20자 → 10자 변경 및 상태코드 200 → 201로 수정 #985
Merged
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeus6768
force-pushed
the
refactor/984-voc-body-length-limit
branch
from
ba357cf to
2923e8a
Compare
HoeSeong123
approved these changes
Dec 23, 2024
| var messageLength10_000 = RandomStringUtils.randomAlphanumeric(10_000); | ||
| return Stream.of(messageLength20, messageLength10_000); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource | ||
| @DisplayName("실패: 문의 내용 길이 19자 이하, 10,001글자 이상") | ||
| @DisplayName("실패: 문의 내용 길이 9자 이하, 10,001글자 이상") |
There was a problem hiding this comment.
문의 내용이 공백으로만 이루어져 있는 경우에 대한 테스트도 추가되면 좋을 것 같아요!
jminkkk
approved these changes
Dec 23, 2024
| @@ -20,6 +21,6 @@ public class VocController implements SpringDocVocController { | |||
| @PostMapping("/contact") | |||
| public ResponseEntity<Void> create(@Valid @RequestBody VocRequest request) { | |||
| vocService.create(request); | |||
| return ResponseEntity.ok().build(); | |||
| return ResponseEntity.status(HttpStatus.CREATED).build(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
#984
📍주요 변경 사항
회의 내용에 따라 글자수 제한을 변경해요.
명세에 따라 문의하기에 성공하면 상태코드 201을 응답하도록 고쳤어요.
🎸기타
관리자 페이지가 생기면 구글 스프레드시트 대신 DB를 사용하는 방식으로 변경돼야 해요.
🍗 PR 첫 리뷰 마감 기한
12/24 21:00