템플릿 CRUD 카테고리, 태그 추가 #275
Merged
템플릿 CRUD 카테고리, 태그 추가 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eEditQuery 테스트 수정
…de-zap into refactor/template_CRUD
vi-wolhwa
approved these changes
Aug 6, 2024
Jaymyong66
approved these changes
Aug 6, 2024
| .env | ||
| .env.development | ||
| .env.production | ||
| .env* |
frontend/src/api/customFetch.ts
Outdated
Comment on lines
37
to
41
| } catch (error) { | ||
| console.error(error); | ||
| throw new Error(errorMessage); | ||
| } | ||
| }; |
There was a problem hiding this comment.
customFetch는 에러 핸들링 관련 PR에서 바뀔거 같긴 해요!
Comment on lines
+40
to
+45
| border-radius: 7px; | ||
| &:hover { | ||
| color: ${({ theme }) => theme.color.light.white}; | ||
| background-color: ${({ theme }) => theme.color.light.primary_500}; | ||
| } | ||
| `; |
There was a problem hiding this comment.
(농담) 7px 말고 8px은 별로였나요 ㅋㅋㅋ
여기 color가 white라면 위에 background-color도 같은 theme 변수를 써도 좋았을거 같아요!
Comment on lines
+47
to
+51
| {options?.map((option, idx) => ( | ||
| <S.Option key={idx} onClick={() => handleCurrentValue(option)}> | ||
| {getOptionLabel(option)} | ||
| </S.Option> | ||
| ))} |
There was a problem hiding this comment.
여기서 options가 옵셔널이 아닌거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #181 #241
📍주요 변경 사항
1. 카테고리, 태그 기능 추가
2. 템플릿 수정, 생성 페이지 컴포넌트 통일 (TemplateEdit)
3. 커스텀 훅 분리
🎸기타
- 아직 리펙토링이 상당히 많이 필요하지만 1차 공유를 위해 먼저 PR 올립니다. 코드리뷰 많이 달아주세요.