Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx reload 스크립트 고침 #1019

Merged
merged 1 commit into from
Jan 6, 2025
Merged

nginx reload 스크립트 고침 #1019

merged 1 commit into from
Jan 6, 2025

Conversation

zeus6768
Copy link
Contributor

@zeus6768 zeus6768 commented Jan 6, 2025

⚡️ 관련 이슈

#833

📍주요 변경 사항

AS-IS

def reload_nginx_config():
    subprocess.run(
        ['docker', 'exec', '-it', 'nginx', 'nginx', '-s', 'reload'],
        stdout=subprocess.PIPE,
        stderr=subprocess.PIPE)

TO-BE

def reload_nginx_config():
    subprocess.run(
        ['docker', 'exec', 'nginx', 'nginx', '-s', 'reload'],
        stdout=subprocess.PIPE,
        stderr=subprocess.PIPE)

🎸기타

고려해야 하는 내용을 작성해 주세요.

🍗 PR 첫 리뷰 마감 기한

ASAP

@zeus6768 zeus6768 added bug 개발자가 의도하지 않은 상황 zap 리뷰 우선순위가 높은 사항 BE 백엔드 infrastructure 인프라 작업 labels Jan 6, 2025
@zeus6768 zeus6768 added this to the 7차 스프린트 💭 milestone Jan 6, 2025
@zeus6768 zeus6768 self-assigned this Jan 6, 2025
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

부디 잘 되길...

@zeus6768 zeus6768 merged commit f0c8d64 into dev/be Jan 6, 2025
5 checks passed
@zeus6768 zeus6768 deleted the fix/cd-nginx-reload branch January 6, 2025 06:19
@zangsu
Copy link
Contributor

zangsu commented Jan 6, 2025

-it 를 붙였을 때 상호작용이 필요해 문제가 있을 것이라 판단.
-it 를 제거

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 bug 개발자가 의도하지 않은 상황 infrastructure 인프라 작업 zap 리뷰 우선순위가 높은 사항
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

4 participants