refactor(controller): 상수 추출

woowacourse-teams · Dec 30, 2024 · 7d94d65 · 7d94d65
1 parent 1536a34
commit 7d94d65
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/backend/src/main/java/codezap/tag/controller/TagController.java b/backend/src/main/java/codezap/tag/controller/TagController.java
@@ -26,7 +26,7 @@ public ResponseEntity<FindAllTagsResponse> getTags(@RequestParam Long memberId)
     }
 
     @GetMapping("/top")
-    public ResponseEntity<FindAllTagsResponse> getTopTags(@RequestParam(defaultValue = "10") int size) {
+    public ResponseEntity<FindAllTagsResponse> getTopTags(@RequestParam(defaultValue = DEFAULT_TOP_TAG_COUNT) int size) {
         FindAllTagsResponse response = tagService.getTopTags(size);
         return ResponseEntity.ok(response);
     }

diff --git a/backend/src/main/java/codezap/tag/service/TagService.java b/backend/src/main/java/codezap/tag/service/TagService.java
@@ -21,6 +21,7 @@
 @Transactional(readOnly = true)
 public class TagService {
 
+    private static final int DEFAULT_POPULAR_DATE_RANGE = 7;
     private final TagRepository tagRepository;
     private final TemplateTagRepository templateTagRepository;
 
@@ -89,7 +90,7 @@ public FindAllTagsResponse getTopTags(int size) {
     }
 
     private List<Tag> findTopTags(int size, LocalDate startDate) {
-        List<Tag> tags = tagRepository.findMostUsedTagsWithinDateRange(size, startDate.minusDays(7));
+        List<Tag> tags = tagRepository.findMostUsedTagsWithinDateRange(size, startDate.minusDays(DEFAULT_POPULAR_DATE_RANGE));
 
         if (tags.size() >= size) {
             return tags;