[BE] 체크리스트 리스트 조회 API를 리팩토링한다. #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-jisong
approved these changes
Sep 20, 2024
tkdgur0906
approved these changes
Sep 20, 2024
# Conflicts: # backend/bang-ggood/src/main/java/com/bang_ggood/checklist/controller/ChecklistController.java # backend/bang-ggood/src/main/java/com/bang_ggood/checklist/dto/response/UserChecklistsPreviewResponse.java # backend/bang-ggood/src/main/java/com/bang_ggood/checklist/service/ChecklistManageService.java # backend/bang-ggood/src/main/java/com/bang_ggood/checklist/service/ChecklistService.java # backend/bang-ggood/src/main/java/com/bang_ggood/like/service/ChecklistLikeService.java # backend/bang-ggood/src/test/java/com/bang_ggood/auth/service/AuthServiceTest.java # backend/bang-ggood/src/test/java/com/bang_ggood/checklist/service/ChecklistManageServiceTest.java # backend/bang-ggood/src/test/java/com/bang_ggood/checklist/service/ChecklistServiceTest.java
tsulocalize
reviewed
Sep 22, 2024
Comment on lines
157
to
161
| private List<ChecklistPreviewResponse> mapToChecklistsPreview(List<Checklist> checklists) { | ||
| return checklists.stream() | ||
| .map(this::mapToChecklistPreview) | ||
| .toList(); | ||
| } |
There was a problem hiding this comment.
이정도 코드도 메서드 분리가 필요할까요?
There was a problem hiding this comment.
분리했을 때 가독성이 훨씬 좋아진다고 생각했습니다!
Comment on lines
100
to
104
| ChecklistPreviewResponse previewResponse1 = response.checklists().get(0); | ||
| ChecklistPreviewResponse previewResponse2 = response.checklists().get(1); | ||
|
|
||
| assertThat(previewResponse1.checklistId()).isEqualTo(checklist2); // 최신순으로 조회 | ||
| assertThat(previewResponse2.checklistId()).isEqualTo(checklist1); |
There was a problem hiding this comment.
containsExactly를 활용해보는 건 어떨까요?
There was a problem hiding this comment.
containsExactly를 사용할 때 객체의 동등성으로 확인하게 되는데 현재 구현방식으로는 동등성을 확인하기 어려워 id값을 확인하는 방식으로 구현했습니다.
Long checklist1 = checklistManageService.createChecklist(user, checklistRequest1);
Long checklist2 = checklistManageService.createChecklist(user, checklistRequest2);
반환값이 id값여서 객체의 동등성을 확인하기 어려워요 🥲
There was a problem hiding this comment.
-> 변수명을 checklist -> checklistId로 변경했습니다.
tsulocalize
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타