[BE] 아티클에 대표이미지를 추가한다. #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-jisong
approved these changes
Sep 20, 2024
| @GetMapping("/articles/latest") | ||
| public ResponseEntity<ArticlesPreviewResponse> readLatestArticles() { | ||
| return ResponseEntity.ok(articleService.readLatestArticles()); | ||
| @GetMapping("/articles/detail") |
There was a problem hiding this comment.
전의 명명이 더 나은 것 같은데 바꾼 이유가 궁금해요!
There was a problem hiding this comment.
- 모든 아티클 조회 API가 최신순으로 불러오기 때문에 latest가 불필요하다고 생각했습니다!
- 일반 목록과 디테일 목록의 엔드포인트를 명확히 분리해주고 싶었습니다!
JINU-CHANG
requested changes
Sep 20, 2024
| public ResponseEntity<ArticlesPreviewResponse> readLatestArticles() { | ||
| return ResponseEntity.ok(articleService.readLatestArticles()); | ||
| @GetMapping("/articles/detail") | ||
| public ResponseEntity<ArticlesDetailPreviewResponse> readArticlesDetail() { |
There was a problem hiding this comment.
Detail과 Preview는 반대되는 개념이라고 생각하는데요,, 일반 목록과 디테일 목록이 어떻게 다른거죠?-?
There was a problem hiding this comment.
저도 detail 명명이 하나를 세부적으로 본다는 것으로 느껴져서 preview와는 대치되는 개념이라 느껴져요!
Partial 등 일부분을 뜻하는 용어를 사용하거나 List 명명을 선택하는 것이 좋을 듯합니다
There was a problem hiding this comment.
DTO 명 수정해주었습니다!
| public ArticlesDetailPreviewResponse readArticles() { | ||
| List<ArticleDetailPreviewResponse> articles = articleRepository.findAll().stream() | ||
| public ArticlesDetailPreviewResponse readArticleDetailPreviews() { | ||
| List<ArticleDetailPreviewResponse> articles = articleRepository.findLatest().stream() |
There was a problem hiding this comment.
Suggested change
| List<ArticleDetailPreviewResponse> articles = articleRepository.findLatest().stream() | |
| List<ArticleDetailPreviewResponse> articles = articleRepository.findLatestArticles().stream() |
…ng-ggood into feat/601-article-thumbnail2 merge dev-be
tsulocalize
force-pushed
the
feat/601-article-thumbnail
branch
from
904a82a
to
d65b273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
아티클 내 thumbnail 추가
DB 구조 변경
📢 논의하고 싶은 내용
API 엔드포인트 바꿨는데 괜찮은지 한번 봐주세요~
🎸 기타