-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] websocket configuration #977
base: develop
Are you sure you want to change the base?
[BE] websocket configuration #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
에러핸들링
아 그러네요... 에러 헨들링쪽은 그때 이야기를 못했었네요.
이거는 한번 더 고민해보고 해야할것같네여 -
JWT 검증
이건 맞아요, 저도 이거 여기에있는거 맘에 안들었었는데,,
나중에 여유나면이나 아니면 다른작업들 좀 순서땜시 붕 뜰때 한번 처리해주면 좋을것같슴다
추가로 하나 확인필요할것같은거 코멘트 남겼어요
+) websocket연결 유지되는거 우리 nginx reversproxy로 쓰고있는데 이거 추가적으로 설정 들어가야할것들 있는지 확인해봐야것네..
registry.addEndpoint("/ws/chat") | ||
.setAllowedOrigins("*") | ||
.withSockJS(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CORS
설정은 왜 있는것일까용...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희가 CORS를 스프링에서 담당하지 않고 엔진엑스에서만하는걸까요? 혹시 몰라 열어둔건데 스프링에서 담당하지 않고 있으면 닫겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넹ㅇ 브라우저랑 연결되는건 nginx라서 닫으면 될것같아용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋아용~~
[BE] PR websocket configuration
이슈번호
PR 내용
웹소켓 handshake 이후 stomp CONNECT 과정 까지의 설정입니다.
참고자료
의논할 거리