Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#506 마이파트를 등록하는 기능을 추가한다 #507
Feat/#506 마이파트를 등록하는 기능을 추가한다 #507
Changes from all commits
21657ab
ef5effb
1e6ca39
1903827
3ee7f92
4909fe9
160dfae
70c242c
f4e6bcc
755cbf9
78e77fb
6a19f5d
9a2b2e7
7445fe0
dea67f7
7933937
28956d8
726937b
0534145
2538e6d
dabb0e2
1eb6d78
4be4363
bc88c8b
f9b85f1
c907719
59c967d
12208bc
15449dd
9b35f7d
b18023b
b8622c0
abba1df
505d557
908d681
bebe44f
eb9d592
725ea97
ce494ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저 이거 갑자기 생각났는데,
모바일에서 sticky 적용한 컴포넌트가
1px만큼 가느다랗게
뒷 배경이 보이는 이슈가 있거든요?top: 49px or margin-top: -1px; 이거 주면 사라지긴 합니다 ㅋㅋ
저도 적용해야겠는데용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
보이시나요? 대략 이런 이슈입니당ㅋㅋㅋ
구글에 쳐도 쫌 많이 나오더라고여
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 해당 이슈가 fixed라고 하는 것 같은데 1px 올려야될까요?
저는 일단 개발자 도구의 device toolbar를 켰을 때만 일어나는 것 같아요.
혹시 실사용하면서 해당 버그가 발생하는가용?
https://bugs.chromium.org/p/chromium/issues/detail?id=1076036
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모바일 개발자 도구에서 확인되는 문제였던걸로! 대화를 통해 해결!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
분리 굿이용~
그런데 가끔 2줄이 되는 노랫말이 있네요. 그래서 테스트를 한번 해봤습니당
+++ 로그인 했다고 가정하고 html로 직접 돔을 추가해서 위에 닉네임이 뜨도록 해봤는데용
코난의 탭 선택시, 스무스 스크롤 148 이동시키는게 살짝 의도와 달라지네요
닉네임 없을때: 스무스 하게 딱 탭 경계선에 걸쳐져서, 스크롤 하면 탭고정 상태로 바로 내려감
닉네임 두고 테스트 해봤을 때: 스무스하게 탭 경계선 살짝 위로 더 올라감
다시 스크롤 하면 탭이 살짝 내려가고 다시 내려감
말로하면 이해가 안될듯해서 영상 남깁니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
커밋된 내용의
ProfileFlex
컴포넌트의 높이를 일정하게 유지시켜서scrollTop을 고정적으로 운용할 수 있도록 스타일을 수정했습니다!
높이의 기준은 자기 소개 3줄 기준입니다.
✍️ 수정 커밋 - 0534145