Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#498 Artist 엔티티 추가, 가수 검색 기능 구현 #502
Feat/#498 Artist 엔티티 추가, 가수 검색 기능 구현 #502
Changes from all commits
8672aa6
82fe989
df3248e
73036d1
f97321d
6cb2fe0
8768c5f
86deb04
cd164ad
84f436f
5cbb92e
97891f8
92b40da
054e5ad
1c475b5
be42a90
8d98dad
9ea320c
fed4bc6
626b645
73c0091
e7c8130
7a0f0c9
da98088
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마찬가지로 노래 정렬이 필요한지 궁금합니다! 검색 결과로 나오는 노래들도 좋아요 정렬이 꼭 필요할까요? 개인적인 생각으로는 무작위로 보여줘도 상관없을 것 같아서요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 스쿼드 내에서 처음에 결정할 때 가수의 노래를 좋아요 순으로 보여주려고 정했었는데요, 아마 정렬을 안하면 id 오름차순으로 반환이 되겠죠? id 오름차순이 더 나을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
만약 중요한 로직이 아니라면 랜덤으로 나와도 상관 없을 것 같다는 생각을 했습니다! 정렬에도 오버헤드가 있기는 하니까요 🤔 바론 생각은 어떠신가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(이전 스쿼드) 스플릿과의 회의 결과 전달드립니다!
현재는 데이터가 많지 않기 때문에 정렬에 소모되는 리소스가 거의 없을 것이라 생각합니다.
베로가 말씀해주신 것 처럼 순서가 중요하지 않을 것 같다는 의견에도 동의하지만, 데이터가 많지 않은 현재 상황에서는 정렬을 굳이 하지 않을 이유도 없을 것 같네요!
이 코멘트는 기억해두었다가 데이터가 많아지는 시점에 적용하도록 하겠습니다. 감사합니다 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서는 저희가 알아서 가수가 중복으로 저장되지 않도록 주의해야 하는 부분이려나요? 🤔 확실히 주의가 필요하겠네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠.. 똑같은 이름의 가수가 똑같은 제목의 노래를 부르는 상황이.. 없겠죠? 이 부분 코드 작성할 때 중복을 체크하지 않기로 한 이유가 있었는데 정확히 기억이 안나네요 😂
같이 논의해보면 좋을 것 같아요!