나만의 칵테일과 관련된 프론트를 구현한다. (미완성) #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 외부 모듈 사용
- 추천 질문과 구분 - 라우트 연결
- Name 컴포넌트 생성
- 클릭시 선택 - api 연결 필요 - 검색 기능 필요
- Slider 필요 - api 필요
KimGyeong
reviewed
Feb 19, 2021
|
|
||
| const onSelect = (e) => { | ||
| const selectedId = e.target.dataset.id; | ||
| const found = glasses.find((it) => it.id == selectedId); |
There was a problem hiding this comment.
Suggested change
| const found = glasses.find((it) => it.id == selectedId); | |
| const found = glasses.find(it => it.id === selectedId); |
There was a problem hiding this comment.
저게 ===로 하니까 동작을 안하더라구...
it.id는 number인데 selectedId는 dataset에서 나올 때에 문자열로 나와서!
그래서 parseInt를 해줬슴니다
const found = glasses.find(it => it.id === parseInt(selectedId));| <div> | ||
| {/*Slider로 수정*/} | ||
| {glasses && | ||
| glasses.map((it) => ( |
There was a problem hiding this comment.
Suggested change
| glasses.map((it) => ( | |
| glasses.map(it => ( |
There was a problem hiding this comment.
이 괄호 유무는 무슨 차이일까용?
뭔가 하나 있을 때는 괄호가 없다!?
내 포매터는 계속 넣어주걸랑..
|
|
||
| const onSelect = (e) => { | ||
| const selectedId = e.target.dataset.id; | ||
| const found = ingredients().find((it) => it.id == selectedId); |
There was a problem hiding this comment.
Suggested change
| const found = ingredients().find((it) => it.id == selectedId); | |
| const found = ingredients().find(it => it.id === selectedId); |
| <Step> | ||
| {({ accomplished, index }) => ( | ||
| <div | ||
| className={`indexed-step ${accomplished ? "accomplished" : null}`} |
There was a problem hiding this comment.
Suggested change
| className={`indexed-step ${accomplished ? "accomplished" : null}`} | |
| className={`indexed-step ${accomplished ? "accomplished" : ""}`} |
이건 확신은 없네요
There was a problem hiding this comment.
아래 아이들도 같이 변경되면 좋겠어요.
아니면 forEach를 돌려서 중복을 줄이는 것도 방법이겠네요
- ===를 사용, null대신 빈 문자열을 사용
KimGyeong
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#263
아직 완전하게 구현된 상황은 아니지만 협업을 위해 우선 pr을 보냅니다.