forked from woowacourse/spring-roomescape-admin
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step2 아토 #2
Open
hyxrxn
wants to merge
27
commits into
woowacourse-6th-code-review-study:hyxrxn
Choose a base branch
from
hyxrxn:step2
base: hyxrxn
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Step2 아토 #2
Commits on Apr 17, 2024
-
[방탈출 예약 관리 - 1~3단계] 아토(이혜린) 미션 제출합니다. (woowacourse#43)
* feat(RoomEscapeController): 홈 화면 생성 Co-authored-by: hyxrxn <[email protected]> * feat(RoomEscapeController): welcome page 리다이렉트 Co-authored-by: hyxrxn <[email protected]> * feat(RoomEscapeController): 예약 내역 조회 Co-authored-by: hyxrxn <[email protected]> * refactor(ReservationDto): 예약 정보 전달 Co-authored-by: hyxrxn <[email protected]> * style(RoomEscapeApplication): 불필요한 개행 삭제 Co-authored-by: hyxrxn <[email protected]> * feat(RoomEscapeController): 예약 추가 Co-authored-by: hyxrxn <[email protected]> * feat(RoomEscapeController): 예약 삭제 Co-authored-by: hyxrxn <[email protected]> * style(RoomEscapeController): 개행 추가 Co-authored-by: hyxrxn <[email protected]> * refactor(ReservationResponse): 클래스명 변경 Co-authored-by: hyxrxn <[email protected]> * fix(index.html): 페이지 이동 불가 버그 개선 Co-authored-by: hyxrxn <[email protected]> * refactor(controller): 컨트롤러 분리 Co-authored-by: hyxrxn <[email protected]> * style(controller): 디폴트값 명시 Co-authored-by: hyxrxn <[email protected]> * refactor(ReservationRequest): LocalDateTime 변환 로직 수정 Co-authored-by: hyxrxn <[email protected]> * style(import): import문 순서 컨벤션 적용 Co-authored-by: hyxrxn <[email protected]> * refactor(Reservation): 불필요한 생성자 제거 * refactor(ReservationRequest): 래퍼 클래스 이용하게 통일 --------- Co-authored-by: Arachneee <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 639f695 - Browse repository at this point
Copy the full SHA 639f695View commit details
Commits on Apr 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 22e85c6 - Browse repository at this point
Copy the full SHA 22e85c6View commit details
Commits on Apr 23, 2024
-
refactor(ReservationController): 예약 내역 조회 시 데이터베이스 활용
- 예약 추가 / 취소 기능 구현 필요
Configuration menu - View commit details
-
Copy full SHA for 8d5e7fa - Browse repository at this point
Copy the full SHA 8d5e7faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 114446c - Browse repository at this point
Copy the full SHA 114446cView commit details -
fix(ReservationController): 예약 추가 및 삭제 시 페이지 미갱신 문제 수정
- 예약 추가 시 해당 예약 바디로 리턴 - reservation-legacy.js에서 상태코드 수정
Configuration menu - View commit details
-
Copy full SHA for b3f2d74 - Browse repository at this point
Copy the full SHA b3f2d74View commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b97eba1 - Browse repository at this point
Copy the full SHA b97eba1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d027c6c - Browse repository at this point
Copy the full SHA d027c6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0d56ce - Browse repository at this point
Copy the full SHA c0d56ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fb9f5b - Browse repository at this point
Copy the full SHA 6fb9f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98ae4d0 - Browse repository at this point
Copy the full SHA 98ae4d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a30029b - Browse repository at this point
Copy the full SHA a30029bView commit details
Commits on Apr 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae0c874 - Browse repository at this point
Copy the full SHA ae0c874View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb2777a - Browse repository at this point
Copy the full SHA eb2777aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2be619 - Browse repository at this point
Copy the full SHA b2be619View commit details
Commits on Apr 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 08e273a - Browse repository at this point
Copy the full SHA 08e273aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78952eb - Browse repository at this point
Copy the full SHA 78952ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for d02fd4b - Browse repository at this point
Copy the full SHA d02fd4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ff3c24 - Browse repository at this point
Copy the full SHA 1ff3c24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 537ae1c - Browse repository at this point
Copy the full SHA 537ae1cView commit details
Commits on Apr 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c914a99 - Browse repository at this point
Copy the full SHA c914a99View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8d9f06 - Browse repository at this point
Copy the full SHA a8d9f06View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc2ac8d - Browse repository at this point
Copy the full SHA cc2ac8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31c3bb6 - Browse repository at this point
Copy the full SHA 31c3bb6View commit details -
refactor(TimeController): 해당 시간의 예약이 존재하는지 확인 후 삭제
- 존재한다면 예외 발생 - 존재하지 않는다면 정상 삭제
Configuration menu - View commit details
-
Copy full SHA for a5136cb - Browse repository at this point
Copy the full SHA a5136cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbb56ad - Browse repository at this point
Copy the full SHA bbb56adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 724c60c - Browse repository at this point
Copy the full SHA 724c60cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a1fa50 - Browse repository at this point
Copy the full SHA 5a1fa50View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.