fix(types): correct 'decrypt_io' param and return type annotations #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was incorrectly parameterized with a "recipients" param rather than "identities." Additionally, it was typed as returning None. This commit addresses both issues and corrects the function annotations so that they align with the rust code, now returning bytes and expecting "identities."
woodruffw
reviewed
Oct 17, 2024
woodruffw
reviewed
Oct 17, 2024
Co-authored-by: William Woodruff <[email protected]>
woodruffw
approved these changes
Oct 19, 2024
|
Thanks for fixing this -- I've released a new patch version of the stubs package, and it should be live on PyPI shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'decrypt_io' function was incorrectly parameterized with a "recipients"
parameter instead of "identities." Additionally, the function was typed as
returning None, but it should return bytes.
This commit corrects both the parameterization and the return type annotations
to align with the Rust code, which expects "identities" and returns bytes.
This may correct an issue that existed prior to my previous commit, but it
was overlooked until now.