Re-add fh streaming possibility

[julianhille]

Adding io input back in.

No idea if that is of any help for anyone else, but at least i need to be able to stream a pyfilelike object.

Feel free to roast all of it as this is my first contact with rust and rust as python module. :>

Fixes #36

[woodruffw]

Thanks @julianhille, I'll try and give this a review today or tomorrow.

[woodruffw]

Looks like the lint is failing; mind running cargo fmt locally?

[woodruffw]

Looks good overall, a few small style nits (plus the lint failures in CI)!

[julianhille]

Looks like the lint is failing; mind running cargo fmt locally?

Just learned about rustfmt and Cargo fmt yesterday. Committed your suggestions, will rebase / Squash format and then get back to you.

If thats OK with you to rebase in the middle of a review.

[julianhille]

Fixed and rebased. Let me know if there is anything else I can do.

[woodruffw]

Some more lint failures:

error: unused variable: `py`
   --> src/lib.rs:263:18
    |
263 | fn from_pyobject(py: Python, file: PyObject, read_only: bool) -> PyResult<PyFileLikeObject> {
    |                  ^^ help: if this is intentional, prefix it with an underscore: `_py`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`

error: unneeded `return` statement
   --> src/lib.rs:265:5
    |
265 |     return PyFileLikeObject::with_requirements(file, read_only, !read_only, false, false);
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `-D clippy::needless-return` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
    |
265 -     return PyFileLikeObject::with_requirements(file, read_only, !read_only, false, false);
265 +     PyFileLikeObject::with_requirements(file, read_only, !read_only, false, false)
    |

error: could not compile `pyrage` (lib) due to 2 previous errors
Error: Process completed with exit code 101.

cargo clippy --fix should fix those.

Also, don't worry about rebasing/squashing -- it's fine to just push, and I'll handle the squash while merging 🙂

[julianhille]

Ah thanks overlooked that. Will get to it.

[julianhille]

tried again. should work now :> thanks for your patience

[julianhille]

Would you mind start the ci run again? Thanks

[woodruffw]

Thanks @julianhille, looks good to me!

[woodruffw]

Let me know if you'd like a release for this. Otherwise, I'll likely do it the next time another feature PR comes in.

[julianhille]

I'd Love a Release. If Not to much effort.

[woodruffw]

Released with v1.2.0. Thanks for your hard work here!