Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v9 #3594

Merged
merged 31 commits into from
Jun 6, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^8.56.0 -> ^9.0.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - "before 4am" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies ui frontend related labels Apr 6, 2024
@renovate renovate bot force-pushed the renovate/eslint-9.x branch 5 times, most recently from 800b5ab to 4baf65e Compare April 8, 2024 06:10
@renovate renovate bot changed the title Update dependency eslint to v9 chore(deps): update dependency eslint to v9 Apr 9, 2024
@renovate renovate bot force-pushed the renovate/eslint-9.x branch 4 times, most recently from ad42132 to 3be8dd1 Compare April 10, 2024 10:35
@qwerty287
Copy link
Contributor

qwerty287 commented Apr 10, 2024

This update is not possible yet because most plugins don't support eslint 9 yet. I started migration work for the other ones

Waiting for:

@qwerty287 qwerty287 marked this pull request as draft April 10, 2024 12:39
@qwerty287 qwerty287 self-assigned this Apr 10, 2024
Copy link
Contributor Author

renovate bot commented Apr 10, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@renovate renovate bot changed the title chore(deps): update dependency eslint to v9 chore(deps): update dependency eslint to v9 - abandoned May 9, 2024
Copy link
Contributor Author

renovate bot commented May 9, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@qwerty287 qwerty287 changed the title chore(deps): update dependency eslint to v9 - abandoned chore(deps): update dependency eslint to v9 May 9, 2024
@renovate renovate bot changed the title chore(deps): update dependency eslint to v9 chore(deps): update dependency eslint to v9 - abandoned May 9, 2024
@qwerty287
Copy link
Contributor

qwerty287 commented Jun 1, 2024

@anbraten I added it in 68f7000 - but now there's one problem: Because we use the same prettier config file, it does not work anymore if you run prettier from the root dir because the plugin is missing.
See https://ci.woodpecker-ci.org/repos/3780/pipeline/16716/24

@qwerty287 qwerty287 added this to the 2.6.0 milestone Jun 1, 2024
@qwerty287
Copy link
Contributor

@anbraten fixed the prettier problem by using a separate config in the web dir importing the root one.

Could you check the remaining issues eslint finds? Then it's good to go.

Also, tsc finds some issues I don't know how to fix: https://ci.woodpecker-ci.org/repos/3780/pipeline/16894/29

@qwerty287 qwerty287 added the refactor delete or replace old code label Jun 6, 2024
@anbraten anbraten marked this pull request as ready for review June 6, 2024 12:56
@anbraten anbraten enabled auto-merge (squash) June 6, 2024 12:57
@qwerty287 qwerty287 changed the title chore(deps): update dependency eslint to v9 - abandoned chore(deps): update dependency eslint to v9 Jun 6, 2024
@anbraten anbraten merged commit 2241474 into main Jun 6, 2024
9 of 13 checks passed
@anbraten anbraten deleted the renovate/eslint-9.x branch June 6, 2024 13:17
@woodpecker-bot
Copy link
Collaborator

@woodpecker-bot woodpecker-bot mentioned this pull request Jun 6, 2024
1 task
@anbraten anbraten mentioned this pull request Jun 10, 2024
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
…i#3594)

Co-authored-by: qwerty287 <[email protected]>
Co-authored-by: qwerty287 <[email protected]>
Co-authored-by: Anbraten <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies refactor delete or replace old code ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants