-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-create WOODPECKER_AGENT_SECRET
secret
#228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ping @xoxys |
xoxys
reviewed
Oct 25, 2024
Co-authored-by: Robert Kaussow <[email protected]>
Co-authored-by: Robert Kaussow <[email protected]>
xoxys
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #144 took a first stab, the implementation does not work in practice for users as the secret is not generated automatically. Right now, only an empty k8s secret is created which must be filled manually with data containing
WOODPECKER_AGENT_SECRET
.As #207 shows, users ideally expect the server-agent connection to work OOB.
This new approach
woodpecker-default-agent-secret
which contains a validWOODPECKER_AGENT_SECRET
createAgentSecret
(default true forserver
), which can be set tofalse
if users want to control the creation themselveswoodpecker-default-agent-secret
will be read by the server and agent (if both are in the same namespace).If the
agent
chart is deployed to a different namespace, users must configure the same secret on their own as we can't ensure the creation of identical secrets across namespaces.fix #207
TODO
Breaking
As this PR changes the way how secrets are created and removes the default
woodpecker-custom-secret
(as this is not in use anymore), this might break existing installations, hence the "breaking" label and major bump.