Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping labels] Add package selection button for Woo Shipping #14024

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

rachelmcr
Copy link
Contributor

Part of: #13550
⚠️ Depends on #14023 ⚠️

Description

This adds a package selection button ("Add a Package") to the new Woo Shipping label creation flow.

The button is in its own WooShippingPackageSelection view, to support the additional package UI that will be added in #13551 (showing e.g. the selected package instead of the button after selecting a package). That issue will also add the button action, to open the package selection UI.

This PR only contains view changes, so there are no view models or unit tests.

Testing information

  1. Install and set up the Woo Shipping extension on your store.
  2. Build and run the app with the revampedShippingLabelCreation feature flag enabled.
  3. Create an order with the processing status and at least one physical product.
  4. In the order details, select "Create Shipping Label."
  5. Ensure the "Add a Package" button appears below the hazmat section in the shipping label creation screen.

Screenshots

Design:

image

Light Dark
Simulator Screenshot - iPhone 16 Pro - 2024-09-23 at 17 59 15 Simulator Screenshot - iPhone 16 Pro - 2024-09-23 at 17 59 26

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@rachelmcr rachelmcr added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Sep 23, 2024
@rachelmcr rachelmcr added this to the 20.6 milestone Sep 23, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14024-09aa98b
Version20.5
Bundle IDcom.automattic.alpha.woocommerce
Commit09aa98b
App Center BuildWooCommerce - Prototype Builds #10966
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from issue/13550-hazmat-section to trunk September 24, 2024 07:29
@rachelmcr rachelmcr merged commit 10065af into trunk Sep 24, 2024
18 of 19 checks passed
@rachelmcr rachelmcr deleted the issue/13550-package-selection branch September 24, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants