[Mobile Payments] Show description for trial tap to pay line items #14022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a merchant tries out tap to pay on iPhone, we make an order which will remain in their history, even though it gets refunded.
To help merchants identify the order, this PR adds a specific description rather than showing
Simple Payment
for these payments.Steps to reproduce
Menu > Payments > Set up/Try out Tap to Pay on iPhone
Try out Tap to Pay on iPhone
Testing information
Note that Simple Payments is only used for Try out Tap to Pay at present, but I've preserved the previous behaviour of having
Simple Payment
as the description when no name is provided. This is covered by unit tests.I have tested the trial payments on an iPhone running iOS 17 and one running iOS 18
Screenshots
try.out.tap.to.pay.label.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: