Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile Payments] Show description for trial tap to pay line items #14022

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Sep 23, 2024

Description

When a merchant tries out tap to pay on iPhone, we make an order which will remain in their history, even though it gets refunded.

To help merchants identify the order, this PR adds a specific description rather than showing Simple Payment for these payments.

Steps to reproduce

  1. Launch the app
  2. Navigate to Menu > Payments > Set up/Try out Tap to Pay on iPhone
  3. Take a trial payment
  4. Find the order in the Orders tab
  5. Observe that the item is named Try out Tap to Pay on iPhone

Testing information

Note that Simple Payments is only used for Try out Tap to Pay at present, but I've preserved the previous behaviour of having Simple Payment as the description when no name is provided. This is covered by unit tests.

I have tested the trial payments on an iPhone running iOS 17 and one running iOS 18

Screenshots

try.out.tap.to.pay.label.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

When a merchant tries out tap to pay on iPhone, we make an order which will remain in their history, even though it gets refunded.

To help merchants identify the order, this adds a specific description rather than showing `Simple Payment` for these payments.
@joshheald joshheald added type: task An internally driven task. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Sep 23, 2024
@joshheald joshheald added this to the 20.6 milestone Sep 23, 2024
@joshheald
Copy link
Contributor Author

@iamgabrielma again not urgent, just fit it in when you can

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 23, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14022-4ac7845
Version20.5
Bundle IDcom.automattic.alpha.woocommerce
Commit4ac7845
App Center BuildWooCommerce - Prototype Builds #10964
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants